Skip to content

Include more guid chars in pipe path - #581

Merged
rosenbjerg merged 5 commits into
mainfrom
include-more-guid-chars-in-pipe-path
Oct 17, 2025
Merged

rosenbjerg merged 5 commits into
mainfrom
include-more-guid-chars-in-pipe-path

Conversation

@rosenbjerg

@rosenbjerg rosenbjerg commented Oct 17, 2025 •

Copy link
Copy Markdown
Owner

@rosenbjerg
rosenbjerg requested a review from Copilot October 17, 2025 17:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Expands the randomness of pipe names and fixes a typo, while adding tests to ensure pipe path lengths stay within macOS limits.

  • Rename GetUnqiuePipeName to GetUniquePipeName
  • Increase GUID substring used in pipe names from 5 to 16 characters
  • Add tests to validate pipe path length is under macOS’s maximum

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File Description
FFMpegCore/FFMpeg/Pipes/PipeHelpers.cs Renames the helper method and increases GUID substring length used in pipe names.
FFMpegCore/FFMpeg/Arguments/PipeArgument.cs Updates call site to the renamed GetUniquePipeName method.
FFMpegCore.Test/ArgumentBuilderTest.cs Adds input/output pipe path length tests and imports Pipes namespace.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread FFMpegCore.Test/ArgumentBuilderTest.cs Outdated
Comment thread FFMpegCore.Test/ArgumentBuilderTest.cs Outdated
Comment thread FFMpegCore.Test/ArgumentBuilderTest.cs Outdated
Comment thread FFMpegCore.Test/ArgumentBuilderTest.cs Outdated
Comment thread FFMpegCore.Test/ArgumentBuilderTest.cs
rosenbjerg and others added 2 commits October 17, 2025 19:53
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.58%. Comparing base (1c4333e) to head (77d13e8).
⚠️ Report is 129 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #581      +/-   ##
==========================================
- Coverage   71.20%   68.58%   -2.62%     
==========================================
  Files         117      122       +5     
  Lines        2973     3467     +494     
  Branches      284      305      +21     
==========================================
+ Hits         2117     2378     +261     
- Misses        751      974     +223     
- Partials      105      115      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants