Repository navigation
Include more guid chars in pipe path - #581
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Expands the randomness of pipe names and fixes a typo, while adding tests to ensure pipe path lengths stay within macOS limits.
- Rename GetUnqiuePipeName to GetUniquePipeName
- Increase GUID substring used in pipe names from 5 to 16 characters
- Add tests to validate pipe path length is under macOS’s maximum
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| FFMpegCore/FFMpeg/Pipes/PipeHelpers.cs | Renames the helper method and increases GUID substring length used in pipe names. |
| FFMpegCore/FFMpeg/Arguments/PipeArgument.cs | Updates call site to the renamed GetUniquePipeName method. |
| FFMpegCore.Test/ArgumentBuilderTest.cs | Adds input/output pipe path length tests and imports Pipes namespace. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #581 +/- ##
==========================================
- Coverage 71.20% 68.58% -2.62%
==========================================
Files 117 122 +5
Lines 2973 3467 +494
Branches 284 305 +21
==========================================
+ Hits 2117 2378 +261
- Misses 751 974 +223
- Partials 105 115 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Sep 20, 2026
This was referenced Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#481