Repository navigation
CI: Install ffmpeg using brew if running on arm64 macos - #576
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #576 +/- ##
=======================================
Coverage 71.20% 71.20%
=======================================
Files 117 117
Lines 2973 2973
Branches 284 284
=======================================
Hits 2117 2117
Misses 751 751
Partials 105 105 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates the CI workflow to better support ARM64 macOS by switching to a different FFmpeg setup action and adjusting the runner configuration. The PR also includes code style improvements by removing redundant public modifiers from interface method declarations.
- Updated macOS runner from
macos-13tomacos-latestfor ARM64 support - Replaced FFmpeg setup action with AnimMouse/setup-ffmpeg for better cross-platform compatibility
- Removed redundant
publicmodifiers from interface method declarations
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .github/workflows/ci.yml | Updated CI workflow to use different FFmpeg setup actions and ARM64 macOS runner |
| FFMpegCore/FFMpeg/Arguments/VideoFiltersArgument.cs | Removed redundant public modifiers from interface properties |
| FFMpegCore/FFMpeg/Arguments/IDynamicArgument.cs | Removed redundant public modifier from interface method |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Migrate to macos-latest (arm64) runners from macos-13 (intel) due to deprecation of intel based macos runners