Skip to content

CI: Install ffmpeg using brew if running on arm64 macos - #576

Merged
rosenbjerg merged 12 commits into
mainfrom
migrate-to-macos-latest-test-runner-instead-of-macos-13
Oct 16, 2025
Merged

rosenbjerg merged 12 commits into
mainfrom
migrate-to-macos-latest-test-runner-instead-of-macos-13

Conversation

@rosenbjerg

@rosenbjerg rosenbjerg commented Oct 16, 2025 •

Copy link
Copy Markdown
Owner

Migrate to macos-latest (arm64) runners from macos-13 (intel) due to deprecation of intel based macos runners

@codecov-commenter

codecov-commenter commented Oct 16, 2025 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.20%. Comparing base (1c4333e) to head (7e135a7).
⚠️ Report is 21 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #576   +/-   ##
=======================================
  Coverage   71.20%   71.20%           
=======================================
  Files         117      117           
  Lines        2973     2973           
  Branches      284      284           
=======================================
  Hits         2117     2117           
  Misses        751      751           
  Partials      105      105           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rosenbjerg
rosenbjerg requested a review from Copilot October 16, 2025 07:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the CI workflow to better support ARM64 macOS by switching to a different FFmpeg setup action and adjusting the runner configuration. The PR also includes code style improvements by removing redundant public modifiers from interface method declarations.

  • Updated macOS runner from macos-13 to macos-latest for ARM64 support
  • Replaced FFmpeg setup action with AnimMouse/setup-ffmpeg for better cross-platform compatibility
  • Removed redundant public modifiers from interface method declarations

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
.github/workflows/ci.yml Updated CI workflow to use different FFmpeg setup actions and ARM64 macOS runner
FFMpegCore/FFMpeg/Arguments/VideoFiltersArgument.cs Removed redundant public modifiers from interface properties
FFMpegCore/FFMpeg/Arguments/IDynamicArgument.cs Removed redundant public modifier from interface method

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/workflows/ci.yml Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants