Repository navigation
Fixed race condition on Named pipe dispose/disconnect - #571
Conversation
…medPipeCleanupRaceCondition Fixed race condition on Named pipe dispose/disconnect
|
fixes this issue: |
|
this is a quick fix minimizing the impact of changes to one class. |
There was a problem hiding this comment.
Pull Request Overview
This PR aims to fix a race condition around disposing and disconnecting a NamedPipeServerStream in PipeArgument by introducing locking around those operations. It also rearranges TestContext properties in tests and slightly reformats one test call for readability.
- Add locking around Pipe dispose (Post) and disconnect (During finally)
- Move TestContext to the top of test classes and reformat a long call argument
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| FFMpegCore/FFMpeg/Arguments/PipeArgument.cs | Adds lock statements around Pipe.Dispose() and Pipe.Disconnect() to prevent races |
| FFMpegCore.Test/VideoTest.cs | Moves TestContext property to top of class (no functional change) |
| FFMpegCore.Test/FFProbeTests.cs | Moves TestContext to top and wraps long call across lines (no functional change) |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #571 +/- ##
==========================================
- Coverage 71.20% 68.58% -2.62%
==========================================
Files 117 122 +5
Lines 2973 3467 +494
Branches 284 305 +21
==========================================
+ Hits 2117 2378 +261
- Misses 751 974 +223
- Partials 105 115 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hey @techtel-pstevens, |
No description provided.