Skip to content

Update SaveM3U8Stream method to use "-codec copy" argument - #445

Merged
rosenbjerg merged 3 commits into
rosenbjerg:mainfrom
rpaschoal:feature/codec-copy
May 21, 2023
Merged

rosenbjerg merged 3 commits into
rosenbjerg:mainfrom
rpaschoal:feature/codec-copy

Conversation

@rpaschoal

Copy link
Copy Markdown
Contributor

By using -codec copy we save time and resources since FFmpeg doesn't need to perform the computationally intensive task of re-encoding the streams.

The improvements on download times are very noticeable with this option.

@tofful tofful left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Patch coverage: 76.92% and project coverage change: +0.32 🎉

Comparison is base (7ebf948) 74.22% compared to head (6c2311c) 74.54%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #445      +/-   ##
==========================================
+ Coverage   74.22%   74.54%   +0.32%     
==========================================
  Files         111      113       +2     
  Lines        2778     2829      +51     
==========================================
+ Hits         2062     2109      +47     
- Misses        716      720       +4     
Impacted Files Coverage Δ
FFMpegCore/FFMpeg/Arguments/CopyCodecArgument.cs 0.00% <0.00%> (ø)
FFMpegCore/FFMpeg/FFMpegArgumentOptions.cs 83.60% <50.00%> (-1.14%) ⬇️
FFMpegCore/FFMpeg/FFMpeg.cs 66.66% <61.53%> (-0.18%) ⬇️
FFMpegCore/FFMpeg/Arguments/GifPaletteArgument.cs 100.00% <100.00%> (ø)
FFMpegCore/FFMpeg/Enums/FileExtension.cs 38.88% <100.00%> (+3.59%) ⬆️
FFMpegCore/FFMpeg/SnapshotArgumentBuilder.cs 80.39% <100.00%> (+26.33%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants