Repository navigation
Add FFMpegCore.Extensions.SkiaSharp - #396
Merged
rosenbjerg merged 29 commits intoFeb 21, 2023
Merged
Conversation
added 18 commits
February 13, 2023 11:07
Changes can be made in a single place if neeeded
Required for successful test execution on my rather slow machine
They are now also supported on Linux because we are using SkiaSharp instead of System.Drawing.Common
Required for execution on Linux, otherwise we get the following error: Unable to load shared library 'libSkiaSharp' or one of its dependencies See mono/SkiaSharp#1341 for more information
…rawing" This reverts commit c96fdc4.
This reverts commit fb19f45.
The two constructors were causing issues with ambiguous method calls but are a good idea, so this is more of a workaround. Error message: The call is ambiguous between the following methods or properties: 'FFMpegCore.Pipes.RawVideoPipeSource.RawVideoPipeSource(System.Collections.Generic.IEnumerator<FFMpegCore.Pipes.IVideoFrame>)' and 'FFMpegCore.Pipes.RawVideoPipeSource.RawVideoPipeSource(System.Collections.Generic.IEnumerable<FFMpegCore.Pipes.IVideoFrame>)'
Owner
|
Hey Dimitri, looks very interesting :) |
rosenbjerg
reviewed
Feb 16, 2023
rosenbjerg
reviewed
Feb 16, 2023
rosenbjerg
reviewed
Feb 16, 2023
rosenbjerg
reviewed
Feb 16, 2023
rosenbjerg
reviewed
Feb 16, 2023
Owner
|
I cannot push changes to your PR btw, although I could resolve the conflicts |
added 3 commits
February 20, 2023 13:18
Codecov ReportBase: 74.85% // Head: 74.18% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #396 +/- ##
==========================================
- Coverage 74.85% 74.18% -0.67%
==========================================
Files 106 109 +3
Lines 2708 2774 +66
==========================================
+ Hits 2027 2058 +31
- Misses 681 716 +35
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
added 4 commits
February 20, 2023 13:48
Execution time is now approximately one fifth of what it was previously
Existing (untouched) tests are not stable in CI test execution
drasive
marked this pull request as ready for review
February 20, 2023 13:31
Author
|
I have verified the visual output with some of my actual uses cases, in addition to the unit tests, and everything seems to work fine. The Codecov checks fail but the code coverage seems fine to me and is on par with the existing code. |
Owner
|
Looks great @drasive |
This was referenced Sep 20, 2026
evgenygunko
pushed a commit
to evgenygunko/Translations
that referenced
this pull request
Sep 26, 2026
> ℹ️ **Note** > > This PR body was truncated due to platform limits. This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [FFMpegCore](https://github.com/rosenbjerg/FFMpegCore) | `5.4.0` → `5.5.0` |  |  | | [LaunchDarkly.ServerSdk](https://github.com/launchdarkly/dotnet-core) | `8.16.2` → `8.17.1` |  |  | | [Moq](https://github.com/moq/moq) | `4.20.72` → `4.21.0` |  |  | | [OpenAI](https://github.com/openai/openai-dotnet/tree/OpenAI_2.14.0) ([source](https://github.com/openai/openai-dotnet)) | `2.13.0` → `2.14.0` |  |  | --- ### Release Notes <details> <summary>rosenbjerg/FFMpegCore (FFMpegCore)</summary> ### [`v5.5.0`](https://github.com/rosenbjerg/FFMpegCore/releases/tag/v5.5.0): FFMpegCore 5.5.0 #### What's Changed - \[Bugfix] Handle joining of non png images by [@​rosenbjerg](https://github.com/rosenbjerg) in [#​397](rosenbjerg/FFMpegCore#397) - Add PackageOutputPath by [@​rosenbjerg](https://github.com/rosenbjerg) in [#​398](rosenbjerg/FFMpegCore#398) - Only upload to codecov on windows by [@​rosenbjerg](https://github.com/rosenbjerg) in [#​406](rosenbjerg/FFMpegCore#406) - Sub video function by [@​slugger7](https://github.com/slugger7) in [#​403](rosenbjerg/FFMpegCore#403) - Add FFMpegCore.Extensions.SkiaSharp by [@​drasive](https://github.com/drasive) in [#​396](rosenbjerg/FFMpegCore#396) - Bump nuget version and cleanup by [@​rosenbjerg](https://github.com/rosenbjerg) in [#​407](rosenbjerg/FFMpegCore#407) - Add a helper method to generate GIF Snapshots by [@​rpaschoal](https://github.com/rpaschoal) in [#​419](rosenbjerg/FFMpegCore#419) - fix: readme minor mistakes. by [@​NaBian](https://github.com/NaBian) in [#​433](rosenbjerg/FFMpegCore#433) - Update SaveM3U8Stream method to use "-codec copy" argument by [@​rpaschoal](https://github.com/rpaschoal)...
This was referenced Sep 26, 2026
This was referenced Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new project and corresponding NuGet package FFMpegCore.Extensions.SkiaSharp. It is based on FFMpegCore.Extensions.SystemDrawingCommon but uses SkiaSharp instead of SystemDrawingCommon, the former being supported on Windows when using .NET 7. See also #381.
FFMpegCore.Test was adjusted so that the tests contibue to be executed for Extensions.SystemDrawingCommon as-is but are also executed for the new Extensions.SkiaSharp implementation.
I have little familiarity with SkiaSharp and cannot vouch for the correctness of the implementation. If it does not pass the bar for being merged, it may still be useful to some or as a starting point.
Areas that could be improved:
I may publish this version of FFMpegCore.Extensions.SkiaSharp to NuGet under the package name "**DimitriVranken.**FFMpegCore.Extensions.SkiaSharp" as not to cause a conflict with a potential later "official" release called "FFMpegCore.Extensions.SkiaSharp".