Proper reusable views support #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stason314
requested review from
disabled,
Antowkos,
artemnovichkov,
ReshetovE and
evgenmikhaylov
artemnovichkov
approved these changes
Jun 28, 2019
Antowkos
suggested changes
Jun 28, 2019
Sources/Extensions/CollectionViewManager+UICollectionViewDataSource.swift
Outdated
Show resolved
Hide resolved
Sources/Protocols/ReuseViewItem/CollectionViewReusableViewItem.swift
Outdated
Show resolved
Hide resolved
Sources/Protocols/ReuseViewItem/CollectionViewReusableViewItem.swift
Outdated
Show resolved
Hide resolved
Antowkos
suggested changes
Jul 18, 2019
ntunin
approved these changes
Jul 18, 2019
Antowkos
approved these changes
Jul 25, 2019
Antowkos
approved these changes
Jul 25, 2019
rosberry
approved these changes
Jul 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement configure reusable view logic like was for cells. Update to swift 5.
Related tasks
ISD-166
Checklist