update char type mapping, update to use separated action types #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
added
in review
mjcarroll
previously approved these changes
Nov 26, 2018
dirk-thomas
force-pushed
the
idl-stage-7
branch
from
fc12bbf
to
6f1a704
Compare
dirk-thomas
force-pushed
the
idl-stage-7
branch
from
6f1a704
to
01a0272
Compare
dirk-thomas
force-pushed
the
idl-stage-7
branch
from
e6aef9c
to
756f1f6
Compare
dirk-thomas
dismissed
mjcarroll’s stale review
Significant changes since initial review
dirk-thomas
added
in progress
dirk-thomas
changed the title
dirk-thomas
added
in review
dirk-thomas
force-pushed
the
idl-stage-7
branch
from
5a83dbb
to
7d12c44
Compare
mjcarroll
approved these changes
Feb 26, 2019
mjcarroll
approved these changes
Feb 27, 2019
dirk-thomas
force-pushed
the
idl-stage-7
branch
from
3bc0f3b
to
d3010ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connected to ros2/rosidl#334.
charin.msgfiles has a value range of[0, 255]according to the ROS 1 docs. Therefore it is being mapped touint8according to https://github.com/ros2/design/blob/gh-pages/articles/143_legacy_interface_definition.md#mapping-to-idl-types