Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update char type mapping, update to use separated action types #315

Merged
merged 7 commits into from
Mar 12, 2019

Conversation

dirk-thomas
Copy link
Member

@dirk-thomas dirk-thomas commented Nov 25, 2018

Connected to ros2/rosidl#334.

char in .msg files has a value range of [0, 255] according to the ROS 1 docs. Therefore it is being mapped to uint8 according to https://github.com/ros2/design/blob/gh-pages/articles/143_legacy_interface_definition.md#mapping-to-idl-types

@dirk-thomas dirk-thomas added the in progress Actively being worked on (Kanban column) label Nov 25, 2018
@dirk-thomas dirk-thomas self-assigned this Nov 25, 2018
@dirk-thomas dirk-thomas added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Nov 26, 2018
mjcarroll
mjcarroll previously approved these changes Nov 26, 2018
@dirk-thomas dirk-thomas mentioned this pull request Feb 12, 2019
8 tasks
@dirk-thomas dirk-thomas dismissed mjcarroll’s stale review February 14, 2019 20:57

Significant changes since initial review

@dirk-thomas dirk-thomas added in progress Actively being worked on (Kanban column) and removed in review Waiting for review (Kanban column) labels Feb 15, 2019
@dirk-thomas dirk-thomas changed the title update char type mapping update char type mapping, update to use separated action types Feb 19, 2019
@dirk-thomas dirk-thomas added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Feb 21, 2019
@dirk-thomas dirk-thomas deleted the idl-stage-7 branch March 12, 2019 04:13
@dirk-thomas dirk-thomas removed the in review Waiting for review (Kanban column) label Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants