Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for waitable #314

Merged
merged 4 commits into from
Nov 22, 2018
Merged

Add test for waitable #314

merged 4 commits into from
Nov 22, 2018

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Nov 22, 2018

Test for C++ waitable with a timer.

Currently test fails (is_ready() returns True, but execute() is never called)

connects to ros2/rclcpp#589

@sloretz sloretz added the in review Waiting for review (Kanban column) label Nov 22, 2018
jacobperron
jacobperron approved these changes Nov 22, 2018
View reviewed changes
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@hidmic hidmic mentioned this pull request Nov 22, 2018
Merged
@jacobperron jacobperron merged commit 394f326 into master Nov 22, 2018
@jacobperron jacobperron deleted the jacob/waitable branch November 22, 2018 22:04
@jacobperron jacobperron removed the in review Waiting for review (Kanban column) label Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobperron jacobperron jacobperron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sloretz @jacobperron @hidmic