Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update security environment variables #200

Merged
merged 1 commit into from
Apr 16, 2020
Merged

Update security environment variables #200

merged 1 commit into from
Apr 16, 2020

Conversation

ruffsl
Copy link
Member

@ruffsl ruffsl commented Apr 14, 2020

Related: #199

@ruffsl
Rename keystore root env from
8fd7296 
ROS_SECURITY_ROOT_DIRECTORY
to
ROS_SECURITY_KEYSTORE

Signed-off-by: ruffsl <roxfoxpox@gmail.com>
@codecov
Copy link

codecov bot commented Apr 14, 2020

Codecov Report

Merging #200 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #200   +/-   ##
=======================================
  Coverage   60.00%   60.00%           
=======================================
  Files          16       16           
  Lines         565      565           
  Branches       52       52           
=======================================
  Hits          339      339           
  Misses        212      212           
  Partials       14       14
Flag Coverage Δ
#unittests 60.00% <100.00%> (ø)
Impacted Files Coverage Δ
sros2/sros2/api/_utilities.py 86.11% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebc1885...8fd7296. Read the comment docs.

@ruffsl ruffsl marked this pull request as ready for review April 14, 2020 16:48
@ruffsl
Copy link
Member Author

ruffsl commented Apr 14, 2020

@ivanpauno could you please run CI for this and accompanied PRs in rcl and system tests?

@ivanpauno
Copy link
Member

@ivanpauno could you please run CI for this and accompanied PRs in rcl and system tests?

CI is a bit red now, I will run it after that is solved.

@ivanpauno ivanpauno merged commit 9c3c42f into master Apr 16, 2020
@ivanpauno ivanpauno deleted the security_env branch April 16, 2020 16:21
@mikaelarguedas mikaelarguedas mentioned this pull request Jun 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyrofa kyrofa kyrofa approved these changes

@ivanpauno ivanpauno ivanpauno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ruffsl @ivanpauno @kyrofa