api: reorganize artifact generation API #195
Conversation
| args.keystore_root_path, args.security_contexts, args.policy_files) | ||
| except FileNotFoundError as e: | ||
| raise RuntimeError(str(e)) | ||
| return 0 if success else 1 | ||
|
|
||
|
|
||
| def _generate_artifacts(keystore_path=None, identity_names=[], policy_files=[]): |
There was a problem hiding this comment.
Note that using lists as default values should probably be fixed in a follow-up.
|
@mikaelarguedas you'll notice I'm not using any git tricks on this one, because I don't know any that work when moving code into a file that already exists. Do you? |
Codecov Report
@@ Coverage Diff @@
## master #195 +/- ##
==========================================
- Coverage 55.38% 54.96% -0.42%
==========================================
Files 17 18 +1
Lines 585 584 -1
Branches 52 52
==========================================
- Hits 324 321 -3
- Misses 247 249 +2
Partials 14 14
Continue to review full report at Codecov.
|
That's where my git-fu stops as well. Git is alledgedly able to track such copies using |
Signed-off-by: Kyle Fazzari <kyle@canonical.com>
Signed-off-by: Kyle Fazzari <kyle@canonical.com>
kyrofa
force-pushed
the
feature/api-clean-artifact-generation
branch
from
a8c331f
to
31d7b1f
Compare
Signed-off-by: Kyle Fazzari <kyle@canonical.com>
…e/api-clean-artifact-generation
kyrofa
force-pushed
the
feature/api-clean-artifact-generation
branch
from
31d7b1f
to
6290890
Compare
|
Alright this should be ready for another pass. |
This PR continues the reorganization of #188 by extracting the artifact generation API into its own module.
Note that this introduces no behavioral changes, it's just moving code around.