-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: reorganize artifact generation API #195
api: reorganize artifact generation API #195
Conversation
args.keystore_root_path, args.security_contexts, args.policy_files) | ||
except FileNotFoundError as e: | ||
raise RuntimeError(str(e)) | ||
return 0 if success else 1 | ||
|
||
|
||
def _generate_artifacts(keystore_path=None, identity_names=[], policy_files=[]): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that using lists as default values should probably be fixed in a follow-up.
@mikaelarguedas you'll notice I'm not using any git tricks on this one, because I don't know any that work when moving code into a file that already exists. Do you? |
Codecov Report
@@ Coverage Diff @@
## master #195 +/- ##
==========================================
- Coverage 55.38% 54.96% -0.42%
==========================================
Files 17 18 +1
Lines 585 584 -1
Branches 52 52
==========================================
- Hits 324 321 -3
- Misses 247 249 +2
Partials 14 14
Continue to review full report at Codecov.
|
That's where my git-fu stops as well. Git is alledgedly able to track such copies using |
Signed-off-by: Kyle Fazzari <kyle@canonical.com>
Signed-off-by: Kyle Fazzari <kyle@canonical.com>
a8c331f
to
31d7b1f
Compare
Signed-off-by: Kyle Fazzari <kyle@canonical.com>
…e/api-clean-artifact-generation
31d7b1f
to
6290890
Compare
Alright this should be ready for another pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This PR continues the reorganization of #188 by extracting the artifact generation API into its own module.
Note that this introduces no behavioral changes, it's just moving code around.