Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file paths for codecov.io #185

Merged
merged 3 commits into from
Apr 2, 2020
Merged

Fix file paths for codecov.io #185

merged 3 commits into from
Apr 2, 2020

Conversation

mikaelarguedas
Copy link
Member

The reason file path were not corrected based on the content of .codecov.yml was because the codecov action removed the ability to pass a custom codecov file.

This PR renames the file to codecov.yml. Browsing files will now work, example of report with this configuration: https://codecov.io/gh/ros2/sros2/tree/c48c44e4c1f97d35c3b82ae85c2712500a7d8d91/sros2/sros2

f71b472 is unrelated to this PR but didn't deserve a PR on its own

Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Copy link
Member

@kyrofa kyrofa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working through that @mikaelarguedas, this will be great to have.

@mikaelarguedas mikaelarguedas merged commit 9756ff4 into master Apr 2, 2020
@mikaelarguedas mikaelarguedas deleted the try_fix_codecov branch April 2, 2020 16:03
@mikaelarguedas mikaelarguedas mentioned this pull request Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants