fix crash(segmentation fault) in propertyHiddenChanged #1587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahcorde
requested changes
Sep 25, 2025
Contributor
ahcorde
left a comment
ahcorde
left a comment
There was a problem hiding this comment.
Do you mind to retarget this to rolling? then I can use mergify to backport this to other distros
kaichie
force-pushed
the
fix-crash-in-property-hidden-change
branch
from
335b038 to
c625d3f
Compare
Contributor
Author
done |
Contributor
|
Pulls: #1587
|
ahcorde
approved these changes
Sep 26, 2025
Contributor
|
https://github.com/Mergifyio backport kilted jazzy humble |
Contributor
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 26, 2025
(cherry picked from commit 9fc8054)
mergify bot
pushed a commit
that referenced
this pull request
Sep 26, 2025
(cherry picked from commit 9fc8054)
This was referenced Sep 26, 2025
mergify bot
pushed a commit
that referenced
this pull request
Sep 26, 2025
(cherry picked from commit 9fc8054) # Conflicts: # rviz_common/src/rviz_common/properties/property_tree_widget.cpp
ahcorde
pushed a commit
that referenced
this pull request
Sep 26, 2025
ahcorde
pushed a commit
that referenced
this pull request
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RViz2 crashes with segmentation fault when reloading robot description (can be reproduce with rapidly toggling the RobotModel display on/off). The crash occurs in PropertyTreeWidget::propertyHiddenChanged()
This PR implements a two-part fix:
QueueConnectiontoDirectConnectionas suggested in call propertyHiddenChanged synchronously #1033Is this user-facing behavior change?
Did you use Generative AI?
No
Additional Information