Skip to content
This repository has been archived by the owner on Dec 9, 2021. It is now read-only.

Add fallback logic in case AMENT_CURRENT_PREFIX is not set #42

Merged
merged 2 commits into from
Sep 16, 2019
Merged

Add fallback logic in case AMENT_CURRENT_PREFIX is not set #42

merged 2 commits into from
Sep 16, 2019

Conversation

jacobperron
Copy link
Member

This is more of a temporary fix, since it would be better to not rely on colcon.

Fixes ros2/rmw_opensplice#283.

@jacobperron
Add fallback logic in case AMENT_CURRENT_PREFIX is not set
5f9f7e2 
This is more of a temporary fix, since it would be better to not rely on colcon.

Fixes ros2/rmw_opensplice#283.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron jacobperron mentioned this pull request Sep 14, 2019
Closed
@jacobperron
Update comment
f23f530 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
dirk-thomas
dirk-thomas approved these changes Sep 14, 2019
View reviewed changes
Copy link
Member

@dirk-thomas dirk-thomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok with me if it resolves the problem for now.

@mkhansenbot
Copy link

Worked for me!

@jacobperron
Copy link
Member Author

jacobperron commented Sep 14, 2019 •
edited
Loading

Full CI with Opensplice:

@jacobperron jacobperron merged commit b834437 into master Sep 16, 2019
@delete-merged-branch delete-merged-branch bot deleted the jacob/ament_prefix_fallback branch September 16, 2019 17:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dirk-thomas dirk-thomas dirk-thomas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Talker demo node fails when run with rmw_opensplice_cpp
3 participants
@jacobperron @mkhansenbot @dirk-thomas