-
Notifications
You must be signed in to change notification settings - Fork 142
rosidl_cli: Add type description support (backport #857) #867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Add type description support to rosidl_cli Signed-off-by: Francisco Rossi <frossi@ekumenlabs.com> * Fix typing annotation Signed-off-by: Francisco Rossi <frossi@ekumenlabs.com> * Please flake8, mypy Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Please flake8 take 2 Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> --------- Signed-off-by: Francisco Rossi <frossi@ekumenlabs.com> Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> Co-authored-by: Michel Hidalgo <michel@ekumenlabs.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Christophe Bedard <bedard.christophe@gmail.com> (cherry picked from commit c9a3084) # Conflicts: # rosidl_cli/rosidl_cli/cli.py # rosidl_cli/rosidl_cli/command/generate/api.py # rosidl_cli/rosidl_cli/command/generate/extensions.py # rosidl_cli/rosidl_cli/command/helpers.py
|
Cherry-pick of c9a3084 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
fujitatomoya
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hidmic can you resolve the conflicts?
|
@fujitatomoya on it |
|
@fujitatomoya FYI #868, once merged this PR will pass CI. |
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
|
Pulls: #867 |
|
@fujitatomoya FYI CI failed but it seems to me it's because of a Jenkins issue? |
|
That Linux job failed again with a Jenkins fluke, but https://build.ros2.org/job/Jpr__rosidl__ubuntu_noble_amd64/11 still pointed me to a linter issue. See #870. |
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
|
Pulls: #867 |
|
Windows CI failed on a missing dependency. @fujitatomoya once you squash merge, DCO failure should go away. The first commit is signed-off. |
This patch adds support for type description generation in
rosidl_cli. It introduces a new hash command to generate type descriptions. It also ensures they are always present as part of thegeneratecommand even if the user doesn't provide them.Addresses #808
Recommended Review Order
I recommend starting with the new
hashgenerator inrosidl_cli/rosidl_cli/command/hash, which utilizes the extension defined inrosidl_generator_type_description/rosidl_generator_type_description/cli.py, and then progressing to the other changes.Notes
rosidl, such asrosidl_pythonandrosidl_typesupport.This is an automatic backport of pull request #857 done by [Mergify](https://mergify.com).