Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename rosidl_generator_c 'namespace' to rosidl_runtime_c #458

Merged
merged 2 commits into from
Apr 11, 2020

Conversation

dirk-thomas
Copy link
Member

@dirk-thomas dirk-thomas commented Apr 11, 2020

Follow up of #442 as part of #446 to match namespace with the package the name the symbols are defined in. Similar to #456.

The two commits in this PR should not be squashed.

Only Linux with linter tests since the change shouldn't have any runtime impact (if it compiles successfully):Build Status

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@dirk-thomas dirk-thomas force-pushed the dirk-thomas/rename-namespaces2 branch from 4ad84af to c6b5d38 Compare April 11, 2020 03:59
@dirk-thomas dirk-thomas merged commit 034e526 into master Apr 11, 2020
@delete-merged-branch delete-merged-branch bot deleted the dirk-thomas/rename-namespaces2 branch April 11, 2020 04:58
dirk-thomas added a commit that referenced this pull request Apr 11, 2020
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@@ -527,7 +527,7 @@ int test_unbounded_sequences()
}

// uint8_values
res = rosidl_generator_c__uint8__Sequence__init(&seq->uint8_values, ARR_SIZE);
res = rosidl_runtime_c__int8__Sequence__init(&seq->uint8_values, ARR_SIZE);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea how I broke this doing search & replace, but this changes from uint8 to int8 results in a compiler warning. See #460.

dirk-thomas added a commit that referenced this pull request Apr 11, 2020
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants