Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests for new message types in test_interface_files #397

Merged
merged 5 commits into from
Aug 27, 2019
Merged

Update tests for new message types in test_interface_files #397

merged 5 commits into from
Aug 27, 2019

Conversation

skucheria
Copy link
Member

dirk-thomas and others added 4 commits August 2, 2019 15:58
@dirk-thomas @skucheria
use latin-1 encoding when reading/writing .idl files, prepend BOM to …
4c3cd0c 
…generated C/C++ files when necessary (#391)

* use utf-8 encoding when reading/writing expanded templates

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>

* inject BOM into generated C/C++ code when necessary

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>

* use latin-1 encoding for .idl files

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Signed-off-by: Siddharth Kucheria <kucheria@usc.edu>
@dirk-thomas @skucheria
use latin-1 encoding when reading/writing .idl files, prepend BOM to …
e5253b0 
…generated C/C++ files when necessary (#391)

* use utf-8 encoding when reading/writing expanded templates

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>

* inject BOM into generated C/C++ code when necessary

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>

* use latin-1 encoding for .idl files

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Signed-off-by: Siddharth Kucheria <kucheria@usc.edu>
@skucheria
Merge branch 'kucheria/add_test_interface_files_cpp' of https://githu…
2e8280e 
…b.com/ros2/rosidl into kucheria/add_test_interface_files_cpp

Signed-off-by: Siddharth Kucheria <kucheria@usc.edu>
@skucheria
Update test_interfaces.cpp
b26ec7f 
Signed-off-by: Siddharth Kucheria <kucheria@usc.edu>
@skucheria skucheria force-pushed the kucheria/add_test_interface_files_cpp branch from aca52eb to b26ec7f Compare August 5, 2019 17:01
@nuclearsandwich nuclearsandwich marked this pull request as ready for review August 15, 2019 14:16
@nuclearsandwich nuclearsandwich added the in review Waiting for review (Kanban column) label Aug 15, 2019
jacobperron
jacobperron reviewed Aug 26, 2019
View reviewed changes
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Some comments below.

rosidl_generator_cpp/test/test_srv_initialization.cpp Show resolved Hide resolved
rosidl_generator_cpp/test/test_msg_initialization.cpp Show resolved Hide resolved
rosidl_generator_cpp/test/test_msg_initialization.cpp Show resolved Hide resolved
rosidl_generator_cpp/test/test_interfaces.cpp Show resolved Hide resolved
@skucheria
Revisions
744c600 
Signed-off-by: Siddharth Kucheria <kucheria@usc.edu>
jacobperron
jacobperron approved these changes Aug 27, 2019
View reviewed changes
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@jacobperron jacobperron merged commit 36bc907 into master Aug 27, 2019
@delete-merged-branch delete-merged-branch bot deleted the kucheria/add_test_interface_files_cpp branch August 27, 2019 21:39
@jacobperron jacobperron mentioned this pull request Aug 30, 2019
Closed
@jacobperron jacobperron mentioned this pull request Oct 14, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobperron jacobperron jacobperron approved these changes

Assignees

@jacobperron jacobperron

Labels
in review Waiting for review (Kanban column)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@skucheria @jacobperron @nuclearsandwich @dirk-thomas