Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle INT32_MIN value #375

Merged
merged 1 commit into from
May 2, 2019
Merged

Handle INT32_MIN value #375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions rosidl_generator_c/rosidl_generator_c/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,10 @@ def basic_value_to_c(type_, value):
return str(value)

if type_.typename == 'int32':
# Handle edge case for INT32_MIN
# Specifically, MSVC is not happy in this case
if -2147483648 == value:
return '({0}l - 1)'.format(value + 1)
return '{value}l'.format_map(locals())

if type_.typename == 'uint32':
Expand Down
4 changes: 4 additions & 0 deletions rosidl_generator_cpp/rosidl_generator_cpp/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,10 @@ def primitive_value_to_cpp(type_, value):
return str(value)

if type_.typename == 'int32':
# Handle edge case for INT32_MIN
# Specifically, MSVC is not happy in this case
if -2147483648 == value:
return '({0}l - 1)'.format(value + 1)
return '%sl' % value

if type_.typename == 'uint32':
Expand Down