Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map ROS char into C signed char #211

Merged
merged 6 commits into from
Apr 6, 2017
Merged

Map ROS char into C signed char #211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c6e45ca
Don't test assigning a negative value to a because it's not portable
gerkey Apr 5, 2017
dea65bf
try mapping char to signed char
gerkey Apr 5, 2017
5db496c
use signed char min/max values
gerkey Apr 5, 2017
00901e5
revert test change and remove unnecessary list item
gerkey Apr 5, 2017
06d9852
update another char to signed char, for the array case
gerkey Apr 5, 2017
88a02b9
trying to get the types right
gerkey Apr 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rosidl_generator_c/include/rosidl_generator_c/primitives_array.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
// array types for all primitive types
ROSIDL_GENERATOR_C__PRIMITIVE_ARRAY(bool, bool)
ROSIDL_GENERATOR_C__PRIMITIVE_ARRAY(byte, uint8_t)
ROSIDL_GENERATOR_C__PRIMITIVE_ARRAY(char, char)
ROSIDL_GENERATOR_C__PRIMITIVE_ARRAY(char, signed char)
ROSIDL_GENERATOR_C__PRIMITIVE_ARRAY(float32, float)
ROSIDL_GENERATOR_C__PRIMITIVE_ARRAY(float64, double)
ROSIDL_GENERATOR_C__PRIMITIVE_ARRAY(int8, int8_t)
Expand Down
2 changes: 1 addition & 1 deletion rosidl_generator_c/rosidl_generator_c/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ def generate_c(generator_arguments_file):
MSG_TYPE_TO_C = {
'bool': 'bool',
'byte': 'uint8_t',
'char': 'char',
'char': 'signed char',
'float32': 'float',
'float64': 'double',
'uint8': 'uint8_t',
Expand Down
2 changes: 1 addition & 1 deletion rosidl_generator_c/src/primitives_array_functions.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
// array functions for all primitive types
ROSIDL_GENERATOR_C__DEFINE_PRIMITIVE_ARRAY_FUNCTIONS(bool, bool)
ROSIDL_GENERATOR_C__DEFINE_PRIMITIVE_ARRAY_FUNCTIONS(byte, uint8_t)
ROSIDL_GENERATOR_C__DEFINE_PRIMITIVE_ARRAY_FUNCTIONS(char, char)
ROSIDL_GENERATOR_C__DEFINE_PRIMITIVE_ARRAY_FUNCTIONS(char, signed char)
ROSIDL_GENERATOR_C__DEFINE_PRIMITIVE_ARRAY_FUNCTIONS(float32, float)
ROSIDL_GENERATOR_C__DEFINE_PRIMITIVE_ARRAY_FUNCTIONS(float64, double)
ROSIDL_GENERATOR_C__DEFINE_PRIMITIVE_ARRAY_FUNCTIONS(int8, int8_t)
Expand Down
8 changes: 4 additions & 4 deletions rosidl_generator_c/test/test_interfaces.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,11 +172,11 @@ int test_primitives(void)
EXPECT_EQ(127, rosidl_generator_c__msg__Constants__TOTO);
EXPECT_EQ(48, rosidl_generator_c__msg__Constants__TATA);

char_msg.empty_char = CHAR_MIN;
EXPECT_EQ(CHAR_MIN, char_msg.empty_char);
char_msg.empty_char = SCHAR_MIN;
EXPECT_EQ(SCHAR_MIN, char_msg.empty_char);

char_msg.empty_char = CHAR_MAX;
EXPECT_EQ(CHAR_MAX, char_msg.empty_char);
char_msg.empty_char = SCHAR_MAX;
EXPECT_EQ(SCHAR_MAX, char_msg.empty_char);

float32_msg.empty_float32 = FLT_MIN;
EXPECT_EQ(FLT_MIN, float32_msg.empty_float32);
Expand Down