Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated byte char #191

Closed
wants to merge 8 commits into from
Closed

Deprecated byte char #191

wants to merge 8 commits into from

Conversation

mikaelarguedas
Copy link
Member

This deprecates byte and char and remaps them to int8 and uint8 repectively
Throws a loud warning at message generation time

Connects to #190

@mikaelarguedas mikaelarguedas added the in progress Actively being worked on (Kanban column) label Dec 13, 2016
@mikaelarguedas mikaelarguedas added ready Work is about to start (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Jul 17, 2017
@clalancette clalancette added this to the bouncy milestone Feb 22, 2018
@mikaelarguedas mikaelarguedas removed this from the bouncy milestone May 7, 2018
@nuclearsandwich
Copy link
Member

One of the packages this pull request targets (rosidl_generator_py) has been moved to https://github.com/ros2/rosidl_python.git

@dirk-thomas
Copy link
Member

Closing since with the transition to IDL these types are not deprecated.

@dirk-thomas dirk-thomas removed the ready Work is about to start (Kanban column) label Apr 16, 2019
@dirk-thomas dirk-thomas deleted the deprecated_byte_char branch April 16, 2019 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants