Handle INT32_MIN value (#375)

Similar to INT64_MIN value, but only because MSVC complains. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
ros2 · May 2, 2019 · 169bf20 · 169bf20
1 parent 4dce828
commit 169bf20
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/rosidl_generator_c/rosidl_generator_c/__init__.py b/rosidl_generator_c/rosidl_generator_c/__init__.py
@@ -147,6 +147,10 @@ def basic_value_to_c(type_, value):
         return str(value)
 
     if type_.typename == 'int32':
+        # Handle edge case for INT32_MIN
+        # Specifically, MSVC is not happy in this case
+        if -2147483648 == value:
+            return '({0}l - 1)'.format(value + 1)
         return '{value}l'.format_map(locals())
 
     if type_.typename == 'uint32':

diff --git a/rosidl_generator_cpp/rosidl_generator_cpp/__init__.py b/rosidl_generator_cpp/rosidl_generator_cpp/__init__.py
@@ -184,6 +184,10 @@ def primitive_value_to_cpp(type_, value):
         return str(value)
 
     if type_.typename == 'int32':
+        # Handle edge case for INT32_MIN
+        # Specifically, MSVC is not happy in this case
+        if -2147483648 == value:
+            return '({0}l - 1)'.format(value + 1)
         return '%sl' % value
 
     if type_.typename == 'uint32':