Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a ReaderWriterFactory utility to share logic for reuse #923

Merged
merged 1 commit into from
Nov 30, 2021

Conversation

emersonknapp
Copy link
Collaborator

Part of #831
Will be wanting to create readers/writers in the Converter implementation, this logic was verbose and required a little too much knowledge. Abstracting it into a Factory simplifies python bindings, and enables reuse.

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
@emersonknapp emersonknapp requested a review from a team as a code owner November 29, 2021 20:11
@emersonknapp emersonknapp requested review from MichaelOrlov, jhdcs and lihui815 and removed request for a team November 29, 2021 20:11
Copy link
Contributor

@lihui815 lihui815 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@emersonknapp
Copy link
Collaborator Author

emersonknapp commented Nov 29, 2021

Gist: https://gist.githubusercontent.com/emersonknapp/8651267c73dac4b9e18d0eb2230fc598/raw/2ef7e47f4adec3db4ba4a3d235e3cfeb32fbd101/ros2.repos
BUILD args: --packages-up-to rosbag2_py rosbag2_transport rosbag2_tests rosbag2
TEST args: --packages-select rosbag2_py rosbag2_transport rosbag2_tests rosbag2
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/9401

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@emersonknapp emersonknapp merged commit 5db0128 into master Nov 30, 2021
@emersonknapp emersonknapp mentioned this pull request Nov 30, 2021
@emersonknapp emersonknapp deleted the emersonknapp/reader-writer-factory branch December 8, 2021 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants