Update PlayOptions::delay to rclcpp::Duration to get nanosecond resolution
#843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…osecond counts so that error messages are readable (move to EXPECT as well) Signed-off-by: Emerson Knapp <eknapp@amazon.com>
|
Windows: |
added 2 commits
August 11, 2021 15:04
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
|
After rclcpp::Duration update - may just be a resolution thing Windows: |
emersonknapp
changed the title
emersonknapp
changed the title
PlayOptions::delay to rclcpp::Duration to get nanosecond resolution
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
|
Fixing compiler warnings - Windows run first: |
|
Rest of the builds
|
emersonknapp
requested review from
prajakta-gokhale
and removed request for
a team
emersonknapp
changed the title
PlayOptions::delay to rclcpp::Duration to get nanosecond resolutionPlayOptions::delay to rclcpp::Duration to get nanosecond resolution
prajakta-gokhale
approved these changes
Aug 13, 2021
WJaworskiRobotec
pushed a commit
to RobotecAI/rosbag2
that referenced
this pull request
Sep 12, 2021
…esolution (ros2#843) * Change type of PlayOptions::delay to rclcpp::Duration Signed-off-by: Emerson Knapp <eknapp@amazon.com> Signed-off-by: Wojciech Jaworski <wojciech.jaworski@robotec.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes failing delay test on Windows (see https://ci.ros2.org/view/nightly/job/nightly_win_deb/2077/#showFailuresLink for example) - which was finishing a few milliseconds early. This is likely due to the resolution of
floatnot carrying the expectations clearly.Additionally, this is a more clear API given that
rclcpp::Durationis strongly typed, rather than having to clarify the units in thePlayOptionsdeclaration.