Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial version of plugin based storage api #7

Merged
merged 59 commits into from
Aug 21, 2018
Merged
Changes from 1 commit
Commits
Show all changes
59 commits
Select commit Hold shift + click to select a range
19171e4
initial version of plugin based storage api
Karsten1987 Jul 18, 2018
cc3b868
rosbag2 serialized message
Karsten1987 Aug 9, 2018
1027a6e
remove colcon ignores
Karsten1987 Aug 9, 2018
f584c2b
Fix build and uncrustify
botteroa-si Aug 2, 2018
c198dc7
Add readable and writable storage interfaces
botteroa-si Aug 2, 2018
8df6de2
Delete first storage interface proposal and adapt storage factory to …
botteroa-si Aug 2, 2018
2ae2a74
Modify test to work with new storage interfaces
botteroa-si Aug 2, 2018
830e414
Prevent pluginlib from using boost
Martin-Idel-SI Aug 6, 2018
984e93e
Introduce better logging using rcutils in rosbag_storage
botteroa-si Aug 8, 2018
53a900c
Add visibility control for Windows in rosbag_storage
botteroa-si Aug 7, 2018
5934ff0
Rename visibility_control.h to visibility_control.hpp
botteroa-si Aug 7, 2018
29f24b2
Fix package.xml in rosbag2_storage
botteroa-si Aug 8, 2018
c39ae4f
Cleanup CMakeLists in rosbag2_storage
Martin-Idel-SI Aug 7, 2018
9990315
Adapt read() and write() methods signature
botteroa-si Aug 2, 2018
009fd4a
Use void * instead of char * in rosbag_storage
botteroa-si Aug 8, 2018
1ea3a55
Add storage facade for plugins which are both readable and writable
Martin-Idel-SI Aug 8, 2018
18fa565
Extract bag_info struct to own file
Martin-Idel-SI Aug 8, 2018
1000d52
Change storage interface to have read/write access
Martin-Idel-SI Aug 9, 2018
956ba79
Add visibility to template specializations
Martin-Idel-SI Aug 10, 2018
b64f192
Remove no longer necessary File install from CMakeLists.txt
botteroa-si Aug 10, 2018
96ab9a8
Refactor storage_factory_impl.hpp
botteroa-si Aug 10, 2018
4aa5d5c
Minor refactoring
botteroa-si Aug 10, 2018
cf4be5a
Fix Windows warning
botteroa-si Aug 10, 2018
b5b3408
Add COLCON_IGNORE files to irrelevant projects
botteroa-si Aug 10, 2018
3b7e7a7
Simpler class hierarchy without WritableStorage
Martin-Idel-SI Aug 13, 2018
77d67b8
Use exceptions instead of bool returns everywhere in interface
Martin-Idel-SI Aug 13, 2018
8f798e7
Change rosbag2_storage interface
Martin-Idel-SI Aug 13, 2018
8d97a2e
Adapt sqlite3 plugin to new interface and extract rosbag2 part to own…
botteroa-si Aug 2, 2018
15ab22e
Update plugin_description.xml and write() method
botteroa-si Aug 8, 2018
311e5a3
Remove Sqlite dependencies from rosbag2 tests
botteroa-si Aug 7, 2018
4d47f92
Add tests to rosbag2_storage_default_plugins
botteroa-si Aug 7, 2018
fe14697
Adapt interface and introduce better logging
botteroa-si Aug 8, 2018
b365d97
Adapt copyright and use copyright linter
Martin-Idel-SI Aug 9, 2018
3136b89
Add plugin development documentation
Martin-Idel-SI Aug 6, 2018
eda1275
storage interfaces
Karsten1987 Aug 14, 2018
9a01e89
linters
Karsten1987 Aug 14, 2018
65500c3
a bit of refactoring
Karsten1987 Aug 15, 2018
e93e561
expose opening and closing
Karsten1987 Aug 15, 2018
bd25b45
take messages as shared ptr
Karsten1987 Aug 15, 2018
fa3d1e9
linters
Karsten1987 Aug 15, 2018
371040b
rename to open, unique_ptr for pimpl
Karsten1987 Aug 17, 2018
a5f038e
remove obsolete api
Karsten1987 Aug 17, 2018
24fb900
comply with new interfaces
Karsten1987 Aug 17, 2018
8f60c8c
change templated open to explicit open_ro and open_rw
Karsten1987 Aug 20, 2018
a64ca6a
Delete superfluous classes + polishing
Martin-Idel-SI Aug 20, 2018
ad601bd
Adapt SerializedBagMessage format
Martin-Idel-SI Aug 20, 2018
9221fcc
Let sqlite3 storage use new interface
Martin-Idel-SI Aug 20, 2018
f1e6500
Fix tests in rosbag2
Martin-Idel-SI Aug 20, 2018
45ece72
Write and read only data
Martin-Idel-SI Aug 20, 2018
7051d51
Replace creation of shared instance by unmanaged instance
Martin-Idel-SI Aug 20, 2018
4d66842
Add pragma for windows
Martin-Idel-SI Aug 20, 2018
2fb1fda
Add visibility control for Windows
Martin-Idel-SI Aug 20, 2018
bd37ba1
Expose template definitions
Martin-Idel-SI Aug 20, 2018
e15912b
Move const to better location
Martin-Idel-SI Aug 20, 2018
15c1d64
Replace strcpy
Martin-Idel-SI Aug 20, 2018
977eda7
Delete superfluous methods
Martin-Idel-SI Aug 21, 2018
6e6ae9c
Use visibility control in rosbag2
Martin-Idel-SI Aug 21, 2018
3dfc8f5
Minor cleanup
Martin-Idel-SI Aug 21, 2018
3892751
test for nullptr when opening storage
Karsten1987 Aug 21, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Delete superfluous methods
  • Loading branch information
Martin-Idel-SI authored and Karsten1987 committed Aug 21, 2018
commit 977eda72adc000c769c0671930edfa52fdd4bbf8
10 changes: 0 additions & 10 deletions rosbag2_storage/include/rosbag2_storage/storage_factory.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -55,16 +55,6 @@ class ROSBAG2_STORAGE_PUBLIC StorageFactory
std::unique_ptr<StorageFactoryImpl> impl_;
};

template<>
ROSBAG2_STORAGE_PUBLIC
std::shared_ptr<storage_interfaces::ReadOnlyInterface> StorageFactory::open(
const std::string & uri, const std::string & storage_id);

template<>
ROSBAG2_STORAGE_PUBLIC
std::shared_ptr<storage_interfaces::ReadWriteInterface> StorageFactory::open(
const std::string & uri, const std::string & storage_id);

} // namespace rosbag2_storage

#ifdef _WIN32
Expand Down