Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

introduce ros2 bag list <plugins> #468

Merged
merged 2 commits into from
Jul 23, 2020
Merged

introduce ros2 bag list <plugins> #468

merged 2 commits into from
Jul 23, 2020

Conversation

Karsten1987
Copy link
Collaborator

Fixes #80

This introduces a new verb for ros2 bag called list which lets you choose between the various types of plugins currently featured in rosbag2. At the time of writing this is storage and converter.

A --verbose output looks like:

 ➭ ros2 bag list storage --verbose
available storage plugins are:
name: sqlite3
	Plugin to write to SQLite3 databases
	type: rosbag2_storage_plugins::SqliteStorage
	base_class: rosbag2_storage::storage_interfaces::ReadWriteInterface
name: my_test_plugin
	This is a test storage plugin.
	type: TestPlugin
	base_class: rosbag2_storage::storage_interfaces::ReadWriteInterface

which is essentially parsing the pluginlib xml file found in the ament resource index.

@Karsten1987
introduce ros2 bag list <plugins>
204baa5 
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
@Karsten1987 Karsten1987 self-assigned this Jul 22, 2020
Karsten1987
Karsten1987 commented Jul 22, 2020
View reviewed changes
emersonknapp
emersonknapp approved these changes Jul 22, 2020
View reviewed changes
Copy link
Collaborator

@emersonknapp emersonknapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Karsten1987
Copy link
Collaborator Author

Karsten1987 commented Jul 23, 2020 •
edited
Loading

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status // known issue

@Karsten1987
Copy link
Collaborator Author

@ros-pull-request-builder retest this please

@Karsten1987 Karsten1987 merged commit 3e9b787 into master Jul 23, 2020
@delete-merged-branch delete-merged-branch bot deleted the list_verb branch July 23, 2020 17:42
emersonknapp pushed a commit that referenced this pull request Feb 2, 2021
@Karsten1987
introduce ros2 bag list <plugins> (#468)
678bb98 
* introduce ros2 bag list <plugins>

Signed-off-by: Karsten Knese <karsten@openrobotics.org>

* Apply suggestions from code review
emersonknapp pushed a commit that referenced this pull request Feb 17, 2021
@Karsten1987
introduce ros2 bag list <plugins> (#468)
cc36fc8 
* introduce ros2 bag list <plugins>

Signed-off-by: Karsten Knese <karsten@openrobotics.org>

* Apply suggestions from code review

Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emersonknapp emersonknapp emersonknapp approved these changes

Assignees

@Karsten1987 Karsten1987

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Print a list of storage (and possibly converter) plugins + description
2 participants
@Karsten1987 @emersonknapp