Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display bag summary using ros2 bag info (reduced size) #45

Merged
merged 14 commits into from
Oct 30, 2018
Merged

Display bag summary using ros2 bag info (reduced size) #45

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
83ad0c2
Display bag summary using `ros2 bag info`
greimela-si Oct 11, 2018
53f448e
Improve process execution helper to handle the working directory
greimela-si Oct 12, 2018
ff240aa
Use metadata filename in sqlite storage to determine database name
greimela-si Oct 12, 2018
1b22db1
GH-109 Write metadata file on Windows by hand
Martin-Idel-SI Oct 17, 2018
fdb1c9b
Remove empty bag folder if record gets aborted and no files are created
botteroa-si Oct 22, 2018
59f3558
Fail gracefully if a runtime error occurs when trying to record or play
botteroa-si Oct 22, 2018
576097c
Log error in case of failing when loading metadata, and minor refacto…
botteroa-si Oct 22, 2018
c8a8c75
Add comment to version field
Martin-Idel-SI Oct 23, 2018
5e09b5f
Allow rosbag2 info without yaml file
Martin-Idel-SI Oct 23, 2018
d5f74ee
GH-7 Don't try to read database name from metadata file when opening …
botteroa-si Oct 24, 2018
9356463
GH-7 Rename 'storage format' into 'serialization format'
botteroa-si Oct 25, 2018
7d26d6a
GH-7 Improve failure conditions
Martin-Idel-SI Oct 30, 2018
e6dacb3
GH-7 Cleanup of superfluous forward declarations
Martin-Idel-SI Oct 30, 2018
4e4b46a
GH-7 Further improve exception handling
Martin-Idel-SI Oct 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fail gracefully if a runtime error occurs when trying to record or play 
- For example if the storage plugin specified by the user at record does not exist
  • Loading branch information
@botteroa-si @Martin-Idel-SI
botteroa-si authored and Martin-Idel-SI committed Oct 29, 2018
commit 59f355804bafb8d5de7cae5c62aa8650c9daa983
24 changes: 16 additions & 8 deletions rosbag2_transport/src/rosbag2_transport/rosbag2_transport.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,12 +62,16 @@ void Rosbag2Transport::shutdown()
void Rosbag2Transport::record(
const StorageOptions & storage_options, const RecordOptions & record_options)
{
writer_->open(storage_options);
try {
writer_->open(storage_options);

auto transport_node = setup_node();
auto transport_node = setup_node();

Recorder recorder(writer_, transport_node);
recorder.record(record_options);
Recorder recorder(writer_, transport_node);
recorder.record(record_options);
} catch (std::runtime_error & e) {
ROSBAG2_TRANSPORT_LOG_ERROR("Failed to record: %s", e.what());
}
}

std::shared_ptr<Rosbag2Node> Rosbag2Transport::setup_node()
Expand All @@ -81,12 +85,16 @@ std::shared_ptr<Rosbag2Node> Rosbag2Transport::setup_node()
void Rosbag2Transport::play(
const StorageOptions & storage_options, const PlayOptions & play_options)
{
reader_->open(storage_options);
try {
reader_->open(storage_options);

auto transport_node = setup_node();
auto transport_node = setup_node();

Player player(reader_, transport_node);
player.play(play_options);
Player player(reader_, transport_node);
player.play(play_options);
} catch (std::runtime_error & e) {
ROSBAG2_TRANSPORT_LOG_ERROR("Failed to play: %s", e.what());
}
}

void Rosbag2Transport::print_bag_info(const std::string & uri)
Expand Down