Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce rosbag2_transport layer and CLI #38

Merged
merged 90 commits into from
Sep 28, 2018
Merged

Introduce rosbag2_transport layer and CLI #38

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
90 commits
Select commit Hold shift + click to select a range
3ae3a46
rosbag2_transport package with python interface
Karsten1987 Aug 25, 2018
3151e52
use cpp for python extension
Karsten1987 Aug 27, 2018
7a3b3df
use rosbag2_transport cpp API
Karsten1987 Aug 27, 2018
f3f0e73
use rosbag2_transport API in cli
Karsten1987 Aug 27, 2018
25c3da6
linters
Karsten1987 Aug 27, 2018
e0a844b
GH-25 Rename target librosbag2 to rosbag2
greimela-si Sep 12, 2018
55c23e2
GH-21 Initial call of rosbag2.record() from rosbag2_transport
greimela-si Sep 12, 2018
200a537
GH-21 Add missing copyright header
greimela-si Sep 13, 2018
ec4352c
GH-21 Cleanup clang tidy issues
greimela-si Sep 13, 2018
ca21e0a
GH-21 Remove rclcpp dependency from rosbag2
greimela-si Sep 13, 2018
b419300
GH-21 Wire rosbag play into CLI
greimela-si Sep 13, 2018
9937f97
GH-21 Add missing test_depend in rosbag2_transport package.xml
greimela-si Sep 13, 2018
1d94085
GH-21 Unify name of python import
greimela-si Sep 13, 2018
146d042
GH-21 Enable -a in CLI, show help on wrong args
greimela-si Sep 13, 2018
5dbea9c
GH-85 Introduce topic and type struct for readability
Martin-Idel-SI Sep 13, 2018
6485950
GH-85 Do not export sqlite3 as dependency from default plugins
Martin-Idel-SI Sep 14, 2018
4369d03
GH-85 Move rosbag2 except typesupport to rosbag2_transport
Martin-Idel-SI Sep 14, 2018
a67739f
GH-85 Add rosbag2 wrapper
Martin-Idel-SI Sep 14, 2018
327515f
GH-85 Change signature of create_topic to take TopicWithType
Martin-Idel-SI Sep 14, 2018
30e018a
GH-85 Use rosbag2 in rosbag2_transport
Martin-Idel-SI Sep 14, 2018
2ba271a
GH-84 Cleanup package.xmls and CMakeLists everywhere
Martin-Idel-SI Sep 14, 2018
e31f417
GH-85 Fix Windows build
Martin-Idel-SI Sep 14, 2018
f831694
GH-21 Add missing init() and shutdown() in record
botteroa-si Sep 14, 2018
67c9d4e
GH-85 Add visibility control to rosbag2
Martin-Idel-SI Sep 14, 2018
08eb248
GH-85 Cleanup and documentation
Martin-Idel-SI Sep 14, 2018
fd1810c
GH-87 Add test package rosbag2_tests
botteroa-si Sep 14, 2018
c495245
GH-87 [WIP] Add first working prototype of an end-to-end test
botteroa-si Sep 14, 2018
011b48c
GH-87 Use test_msgs instead of std_msgs/String in end-to-end test
botteroa-si Sep 17, 2018
ad14c7e
GH-87 Use SIGTERM instead of SIGKILL and refactor test
botteroa-si Sep 17, 2018
181eee5
GH-87 Make end-to-end test work on Windows
Sep 17, 2018
6492b16
GH-87 Fix uncrustify
botteroa-si Sep 17, 2018
818952f
GH-87 Refactor end-to-end test fixture
botteroa-si Sep 17, 2018
877de18
GH-87 Fix test fixture for Windows
Sep 17, 2018
248702b
GH-87 Refactor test fixture
botteroa-si Sep 17, 2018
5514c48
GH-87 Separate record from play end-to-end test
botteroa-si Sep 17, 2018
97e7755
GH-87 Make record end-to-end test work
botteroa-si Sep 17, 2018
e5c5f80
GH-87 Publish before recording to create topic
Martin-Idel-SI Sep 18, 2018
52bf059
GH-21 Extend transport python module interface
greimela-si Sep 17, 2018
e31ddeb
GH-87 Fix record all on Windows
botteroa-si Sep 18, 2018
1720d79
GH-87 Check for topics instead of all
botteroa-si Sep 18, 2018
fcfaaec
GH-87 Wait until rosbag record opened database
Martin-Idel-SI Sep 18, 2018
cdc9875
GH-87 Delete directory recursively
Martin-Idel-SI Sep 18, 2018
8667be7
GH-87 Delete directories recursively on Linux
Martin-Idel-SI Sep 18, 2018
da9cb88
GH-87 Reset ROS_DOMAIN_ID to protect against concurrent tests
Martin-Idel-SI Sep 18, 2018
d9eed08
GH-87 Improve test and refactoring
Martin-Idel-SI Sep 18, 2018
d6e19d5
GH-87 Minor refactoring to increase test readability
Martin-Idel-SI Sep 18, 2018
8035f27
GH-87 Fix Windows build
botteroa-si Sep 18, 2018
357c62d
GH-87 Fix environmental variable behaviour on Mac
botteroa-si Sep 18, 2018
b74842b
GH-89 Make rosbag2 interfaces virtual and add explicit open() method
greimela-si Sep 18, 2018
2a6d6ea
GH-89 Use mock reader and writer in rosbag2_transport tests
greimela-si Sep 18, 2018
5bd985b
GH-87 Add play end_to_end test
botteroa-si Sep 18, 2018
c4cda98
GH-87 Improvements of test
Martin-Idel-SI Sep 19, 2018
4257763
GH-87 Fix Windows build
botteroa-si Sep 19, 2018
69e6de6
GH-89 Cleanup: small documentation fixes.
anhosi Sep 19, 2018
035856e
GH-89 [WIP] Test if Writer and Reader work with class visibility
greimela-si Sep 19, 2018
273211a
GH-87 Stabilize rosbag2_play test
Martin-Idel-SI Sep 19, 2018
c708d31
GH-87 Minor refactoring of tests
Martin-Idel-SI Sep 19, 2018
c85c497
GH-87 Rename end to end tests
Martin-Idel-SI Sep 19, 2018
5bb79ad
add license agreement
Karsten1987 Sep 20, 2018
f82c1c0
GH-89 Simplification of writing to in-memory storage
Martin-Idel-SI Sep 20, 2018
4c9c7a8
GH-89 Stabilize transport tests
Martin-Idel-SI Sep 20, 2018
b4064bc
GH-87 Refactoring of tests
Martin-Idel-SI Sep 20, 2018
b8b98b8
GH-87 Add pytest cache to gitignore
Martin-Idel-SI Sep 20, 2018
94a3a19
GH-87 Refactoring of play test
Martin-Idel-SI Sep 20, 2018
591a47c
GH-87 Extract record test fixture for readability
Martin-Idel-SI Sep 20, 2018
40ad8ba
GH-89 Refactor transport tests
Martin-Idel-SI Sep 20, 2018
40e8649
GH-89 Use temporary directory fixture in sqlite tests
Martin-Idel-SI Sep 20, 2018
eea590c
GH-89 Conform to naming standard for tests
Martin-Idel-SI Sep 20, 2018
49d8f25
GH-89 Prevent burst publishing of all messages
Martin-Idel-SI Sep 20, 2018
7d7919e
GH-89 Improve play stability
Martin-Idel-SI Sep 20, 2018
f3db46c
GH-25 Fix package.xmls
Martin-Idel-SI Sep 21, 2018
98c82f5
Consistently use project name in CMakeLists
Martin-Idel-SI Sep 25, 2018
4026e84
Minor cleanup
Martin-Idel-SI Sep 25, 2018
b2c8223
Change name of nodes in rosbag2_transport
Martin-Idel-SI Sep 25, 2018
4951ff2
Cleanup folder structure in rosbag2_storage and rosbag2_tests
Martin-Idel-SI Sep 25, 2018
7036c8b
Export sqlite3 dependency as package dependency
Martin-Idel-SI Sep 25, 2018
642a75d
Create node in Rosbag2Transport always
Martin-Idel-SI Sep 26, 2018
97cc335
Only hold one node in rosbag2_transport
Martin-Idel-SI Sep 26, 2018
294d647
Move all duplicate files to common package
Martin-Idel-SI Sep 26, 2018
e1e2ac7
Adapt namespacing in test commons package
Martin-Idel-SI Sep 26, 2018
8d4b0c7
Replace "Waiting for messages..." message
Martin-Idel-SI Sep 26, 2018
35c0abb
GH-25 rename rosbag2_test_commons -> rosbag2_test_common
anhosi Sep 27, 2018
33c4f2e
GH-25 Overwrite already existing test.bag when recording
anhosi Sep 27, 2018
c2d414d
GH-25 Cleanups
anhosi Sep 27, 2018
3111fd8
fix cmake typo for test_common
Karsten1987 Sep 27, 2018
534dba0
Remove superfluous loop in rosbag2 transport
Martin-Idel-SI Sep 27, 2018
de966f0
Delete superfluous test_msgs dependency
Martin-Idel-SI Sep 27, 2018
53c9cae
Add rclcpp to test dependencies
Martin-Idel-SI Sep 27, 2018
490697f
Fix rosbag2 node test
Martin-Idel-SI Sep 27, 2018
4939325
Fix dependencies by exporting them explicitly
Martin-Idel-SI Sep 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix dependencies by exporting them explicitly
  • Loading branch information
@Martin-Idel-SI
Martin-Idel-SI committed Sep 27, 2018
commit 4939325a3881d01f88a1ddbb5c9860d1f49c3279
1 change: 0 additions & 1 deletion rosbag2_storage_default_plugins/package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
<test_depend>ament_lint_common</test_depend>
<test_depend>ament_cmake_gmock</test_depend>
<test_depend>rosbag2_test_common</test_depend>
<test_depend>rclcpp</test_depend>

<export>
<build_type>ament_cmake</build_type>
Expand Down
1 change: 1 addition & 0 deletions rosbag2_test_common/package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
<test_depend>ament_lint_auto</test_depend>
<test_depend>ament_lint_common</test_depend>
<test_depend>rclcpp</test_depend>
<build_export_depend>rclcpp</build_export_depend>

<export>
<build_type>ament_cmake</build_type>
Expand Down