Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add correct timing behaviour for rosbag play #32

Merged
merged 27 commits into from
Sep 20, 2018
Merged

Add correct timing behaviour for rosbag play #32

Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
0ddcbeb
GH-69 Read storage content in a separate thread
anhosi Sep 3, 2018
def5392
GH-71 Add integration test for timing behavior
anhosi Sep 3, 2018
cde004c
GH-71 Retain time difference of messages when playing a bag file
anhosi Sep 4, 2018
29dff0e
GH-71 Improve stability of read test
anhosi Sep 4, 2018
ac791f8
GH-71 Fix Classloader instance lifetime
anhosi Sep 4, 2018
fa23d74
GH-71 Extract playing code into a class of its own
anhosi Sep 4, 2018
e92e67d
GH-70 Do not link explicitly against std_msgs
Martin-Idel-SI Sep 4, 2018
5ad39d4
GH-70 Fix error message of storage
Martin-Idel-SI Sep 5, 2018
81bfb1b
GH-70 Fix pluginlib/storage issue for recording
Martin-Idel-SI Sep 5, 2018
c5cda7e
GH-71 Cleanup: variable naming
anhosi Sep 5, 2018
f6489e0
GH-68 Introduce vendor package for shared queue
Martin-Idel-SI Sep 3, 2018
71eac49
GH-70 Load storage continuously instead of as fast as possible
Martin-Idel-SI Sep 10, 2018
0f0f94e
GH-70 Add options struct to allow specification of queue size
Martin-Idel-SI Sep 10, 2018
9f67dbb
GH-72 Wait for messages to fill up
Martin-Idel-SI Sep 10, 2018
d9c87d8
GH-74 Rename integration tests to play/record tests
Martin-Idel-SI Sep 10, 2018
4b5cc9e
GH-74 Use test_msgs in integration tests
Martin-Idel-SI Sep 10, 2018
75e8e35
GH-70 Rename is_not_ready to is_pending, use bulk reading to queue
greimela-si Sep 10, 2018
6ab44a0
GH-70 Harmonize storage_loading_future variable
greimela-si Sep 10, 2018
3921211
GH-88 Read messages in order of their timestamps
Martin-Idel-SI Sep 14, 2018
3be2292
Fix compiler error on Mac
botteroa-si Sep 14, 2018
3345e20
GH-8 Fix: use correct ros message type in test
anhosi Sep 17, 2018
3665a34
GH-8 Cleanup: minor code style fixes
anhosi Sep 18, 2018
463d721
GH-8 Refactor future usage in player
anhosi Sep 18, 2018
3117261
GH-8 Cleanup: remove verbose logging for every stored message
anhosi Sep 18, 2018
f3da51f
GH-8 Refactor rosbag2 interface
anhosi Sep 18, 2018
08cfd51
fix: call vector.reserve instead of default initalization
Karsten1987 Sep 18, 2018
5f89708
fix record demo
Karsten1987 Sep 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
GH-70 Fix error message of storage
  • Loading branch information
@Martin-Idel-SI @greimela-si
Martin-Idel-SI authored and greimela-si committed Sep 19, 2018
commit 5ad39d43263bc77f5a59341565414f5964f3bdbd
12 changes: 8 additions & 4 deletions rosbag2_storage/src/impl/storage_factory_impl.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,10 @@ class StorageFactoryImpl
{
auto instance = get_interface_instance(read_write_class_loader_, storage_id, uri);

ROSBAG2_STORAGE_LOG_ERROR_STREAM(
"Could not load/open plugin with storage id '" << storage_id << "'.");
if (instance == nullptr) {
ROSBAG2_STORAGE_LOG_ERROR_STREAM(
"Could not load/open plugin with storage id '" << storage_id << "'.");
}

return instance;
}
Expand All @@ -125,8 +127,10 @@ class StorageFactoryImpl
read_write_class_loader_, storage_id, uri);
}

ROSBAG2_STORAGE_LOG_ERROR_STREAM(
"Could not load/open plugin with storage id '" << storage_id << "'.");
if (instance == nullptr) {
ROSBAG2_STORAGE_LOG_ERROR_STREAM(
"Could not load/open plugin with storage id '" << storage_id << "'.");
}

return instance;
}
Expand Down