Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record all topics #30

Merged
merged 13 commits into from
Sep 11, 2018
Merged

Record all topics #30

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
01947ca
GH-23 Get all topics from node and sanitize
Martin-Idel-SI Aug 29, 2018
c4098b2
GH-23 Allow to write all available topics
Martin-Idel-SI Aug 30, 2018
2351161
GH-23 Move methods to node for better interface
Martin-Idel-SI Aug 29, 2018
9b1eb50
GH-23 Use rmw_serialized_message_t consistently
Martin-Idel-SI Aug 29, 2018
c48c545
GH-23 Improve santization of topics
Martin-Idel-SI Aug 29, 2018
363cc67
GH-65 Introduce and use better logging macros
Martin-Idel-SI Aug 29, 2018
9f7701e
GH-23 Use publisher to serialized message directly
Martin-Idel-SI Aug 30, 2018
9cb06da
GH-23 Improve readability of sanitizing topics and types
Martin-Idel-SI Aug 30, 2018
8ffae59
GH-23 Add test for record all
Martin-Idel-SI Aug 30, 2018
0eb18eb
GH-23 Cleanup: add missing const ref to record interface
anhosi Sep 5, 2018
2a6c423
Cleanup for doxygen
Martin-Idel-SI Sep 11, 2018
f1a173b
Improve topic sanitization
Martin-Idel-SI Sep 11, 2018
7d77905
Pass topic_name by reference
Martin-Idel-SI Sep 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
GH-23 Use rmw_serialized_message_t consistently
  • Loading branch information
@Martin-Idel-SI @anhosi
Martin-Idel-SI authored and anhosi committed Sep 5, 2018
commit 9b1eb5033e2c6c79e319f412464c8722b93bac5c
2 changes: 1 addition & 1 deletion rosbag2/src/rosbag2/rosbag2_node.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ std::shared_ptr<GenericPublisher> Rosbag2Node::create_generic_publisher(
std::shared_ptr<GenericSubscription> Rosbag2Node::create_generic_subscription(
const std::string & topic,
const std::string & type,
std::function<void(std::shared_ptr<rcutils_char_array_t>)> callback)
std::function<void(std::shared_ptr<rmw_serialized_message_t>)> callback)
{
auto type_support = get_typesupport(type);

Expand Down
2 changes: 1 addition & 1 deletion rosbag2/src/rosbag2/rosbag2_node.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ class Rosbag2Node : public rclcpp::Node
std::shared_ptr<GenericSubscription> create_generic_subscription(
const std::string & topic,
const std::string & type,
std::function<void(std::shared_ptr<rcutils_char_array_t>)> callback);
std::function<void(std::shared_ptr<rmw_serialized_message_t>)> callback);

std::map<std::string, std::string>
get_topics_with_types(const std::vector<std::string> & topic_names);
Expand Down