Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change plugin_development documentation to reflect interface change #29

Merged
merged 1 commit into from
Sep 5, 2018
Merged

Change plugin_development documentation to reflect interface change #29

merged 1 commit into from
Sep 5, 2018

Conversation

Martin-Idel-SI
Copy link
Contributor

In our branch, we initially added some documentation on how to write storage plugins.

This PR updates the documentation with all changes pushed to master.

@Karsten1987 Karsten1987 merged commit 52d5ab3 into ros2:master Sep 5, 2018
@anhosi anhosi deleted the feature/update_plugin_development_documentation branch September 5, 2018 17:04
james-rms pushed a commit to james-rms/rosbag2 that referenced this pull request Nov 17, 2022
@jtbandes @james-rms
Test Foxy & Galactic in CI, fix missing test_depends in mcap_vendor/p…
844be92 
…ackage.xml (ros2#33)

Fix build failure for galactic and test foxy/galactic in CI.

Foxy build currently fails (ros2#29). We can fix it in the future, or remove it if it’s impractical to fix it.
james-rms pushed a commit to james-rms/rosbag2 that referenced this pull request Nov 17, 2022
@jtbandes @james-rms
Test Foxy & Galactic in CI, fix missing test_depends in mcap_vendor/p…
6b7c98b 
…ackage.xml (ros2#33)

Fix build failure for galactic and test foxy/galactic in CI.

Foxy build currently fails (ros2#29). We can fix it in the future, or remove it if it’s impractical to fix it.

Signed-off-by: James Smith <james@foxglove.dev>
james-rms pushed a commit to james-rms/rosbag2 that referenced this pull request Nov 18, 2022
@jtbandes @james-rms
Test Foxy & Galactic in CI, fix missing test_depends in mcap_vendor/p…
5be0251 
…ackage.xml (ros-tooling/rosbag_storage_mcap#33)

Fix build failure for galactic and test foxy/galactic in CI.

Foxy build currently fails (ros2#29). We can fix it in the future, or remove it if it’s impractical to fix it.

Signed-off-by: James Smith <james@foxglove.dev>
james-rms pushed a commit to james-rms/rosbag2 that referenced this pull request Nov 18, 2022
@jtbandes @james-rms
Test Foxy & Galactic in CI, fix missing test_depends in mcap_vendor/p…
589e8f6 
…ackage.xml (ros-tooling/rosbag2_storage_mcap#33)

Fix build failure for galactic and test foxy/galactic in CI.

Foxy build currently fails (ros2#29). We can fix it in the future, or remove it if it’s impractical to fix it.

Signed-off-by: James Smith <james@foxglove.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Karsten1987 Karsten1987 Karsten1987 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Martin-Idel-SI @Karsten1987 @tfoote