Bugfix: Player can't play with read_ahead_queue_size equal 1 #2174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Orlov <morlovmr@gmail.com>
MichaelOrlov
force-pushed
the
morlov/bugfix-for-palyback-with-queue-size-1
branch
from
29d50bf to
1c206db
Compare
MichaelOrlov
requested review from
Barry-Xu-2018,
christophebedard and
fujitatomoya
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
christophebedard
approved these changes
Sep 17, 2025
Co-Authored by: Christophe Bedard <bedard.christophe@gmail.com> Co-authored-by: Christophe Bedard <bedard.christophe@gmail.com> Signed-off-by: Michael Orlov <morlovmr@gmail.com>
Contributor
Author
|
Pulls: #2174
|
Contributor
Author
|
CI failed due to the massive CI infrastructure outage with errors like E: Failed to fetch http://ports.ubuntu.com/ubuntu-ports/dists/noble-security/universe/binary-arm64/Packages.gz File has unexpected size (1110837 != 1110832). Mirror sync in progress? [IP: 91.189.91.104 80]
16:11:08 Hashes of expected file:
16:11:08 - Filesize:1110832 [weak]
16:11:08 - SHA256:5b61d1eb2248baeaca320473c80afb8df1c095dcebf56a8fde807161310ca5a5
16:11:08 - SHA1:26f9e3570aef58d2369665d69340058955dbcfa4 [weak]
16:11:08 - MD5Sum:eb3de2c6410ab8862c6d2bfc9cccccc3 [weak]
16:11:08 Release file created at: Thu, 18 Sep 2025 19:28:46 +0000
16:11:08 E: Some index files failed to download. They have been ignored, or old ones used instead.Two CI jobs auto-restarted and passed green
|
Contributor
Author
|
re-run
|
Contributor
Author
|
The CI has not been doing very well in the last few days. The failed Ci job auto-restarted and passed green
|
MichaelOrlov
deleted the
morlov/bugfix-for-palyback-with-queue-size-1
branch
Contributor
Author
|
https://github.com/Mergifyio backport kilted jazzy |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 19, 2025
* Bugfix: Player can't play with read_ahead_queue_size equal 1 Signed-off-by: Michael Orlov <morlovmr@gmail.com> * Add missing deserialize_test_message() from #2172 Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Address review comments Co-Authored by: Christophe Bedard <bedard.christophe@gmail.com> Co-authored-by: Christophe Bedard <bedard.christophe@gmail.com> Signed-off-by: Michael Orlov <morlovmr@gmail.com> --------- Signed-off-by: Michael Orlov <morlovmr@gmail.com> Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Co-authored-by: Christophe Bedard <bedard.christophe@gmail.com> (cherry picked from commit 951d175)
mergify bot
pushed a commit
that referenced
this pull request
Sep 19, 2025
* Bugfix: Player can't play with read_ahead_queue_size equal 1 Signed-off-by: Michael Orlov <morlovmr@gmail.com> * Add missing deserialize_test_message() from #2172 Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Address review comments Co-Authored by: Christophe Bedard <bedard.christophe@gmail.com> Co-authored-by: Christophe Bedard <bedard.christophe@gmail.com> Signed-off-by: Michael Orlov <morlovmr@gmail.com> --------- Signed-off-by: Michael Orlov <morlovmr@gmail.com> Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Co-authored-by: Christophe Bedard <bedard.christophe@gmail.com> (cherry picked from commit 951d175) # Conflicts: # rosbag2_transport/test/rosbag2_transport/rosbag2_transport_test_fixture.hpp
MichaelOrlov
added a commit
that referenced
this pull request
Sep 23, 2025
…2179) * Bugfix: Player can't play with read_ahead_queue_size equal 1 * Add missing deserialize_test_message() from #2172 * Address review comments Co-Authored by: Christophe Bedard <bedard.christophe@gmail.com> --------- (cherry picked from commit 951d175) Signed-off-by: Michael Orlov <morlovmr@gmail.com> Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Co-authored-by: Michael Orlov <morlovmr@gmail.com> Co-authored-by: Christophe Bedard <bedard.christophe@gmail.com>
MichaelOrlov
added a commit
that referenced
this pull request
Sep 23, 2025
…(backport #2174) (#2180) * Bugfix: Player can't play with read_ahead_queue_size equal 1 (#2174) * Bugfix: Player can't play with read_ahead_queue_size equal 1 Signed-off-by: Michael Orlov <morlovmr@gmail.com> * Add missing deserialize_test_message() from #2172 Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Address review comments Co-Authored by: Christophe Bedard <bedard.christophe@gmail.com> Co-authored-by: Christophe Bedard <bedard.christophe@gmail.com> Signed-off-by: Michael Orlov <morlovmr@gmail.com> --------- Signed-off-by: Michael Orlov <morlovmr@gmail.com> Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Co-authored-by: Christophe Bedard <bedard.christophe@gmail.com> (cherry picked from commit 951d175) # Conflicts: # rosbag2_transport/test/rosbag2_transport/rosbag2_transport_test_fixture.hpp * Address merge conflicts Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Adjust test for absence of the "play_options_.message_order" Signed-off-by: Michael Orlov <michael.orlov@apex.ai> --------- Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Co-authored-by: Michael Orlov <morlovmr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bugfix: for the situation when Player can't play with
--read-ahead-queue-sizeorrosbag2_transport::PlayOptions::read_ahead_queue_sizeequal 1.Is this user-facing behavior change?
Yes. User will be able to use playback with
--read-ahead-queue-size 1CLI option.Did you use Generative AI?
Yes. I am using GitHub Copilot, GPT-4.1 in my workflow.
Additional Information
The fix can be backported