Skip to content

Address clang warning in the TimeControllerClock::wakeup() (backport #1962) #1977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2025
Merged

Address clang warning in the TimeControllerClock::wakeup() (backport #1962) #1977

merged 1 commit into from
Apr 24, 2025
+9 −0

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Apr 24, 2025

  • This PR will suppress the clang warning in the TimeControllerClock::wakeup().

I saw this warning on this clang nightly CI job https://ci.ros2.org/view/nightly/job/nightly_linux_clang_libcxx/2219/clang/folder.535941802/source.4a5d9a19-e847-4d34-b16a-7d33e0a22acb/#203

This is an automatic backport of pull request #1962 done by Mergify.

@ahcorde @MichaelOrlov @mergify
Address clang warning in the TimeControllerClock::wakeup() (#1962)
ac7143b 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Co-authored-by: Michael Orlov <morlovmr@gmail.com>
(cherry picked from commit 70372cc)
@mergify mergify bot requested a review from a team as a code owner April 24, 2025 17:31
@mergify mergify bot requested review from MichaelOrlov and hidmic and removed request for a team April 24, 2025 17:31
@mergify mergify bot mentioned this pull request Apr 24, 2025
Merged
@ahcorde
Copy link
Contributor

ahcorde commented Apr 24, 2025 •
edited
Loading

Pulls: #1977
Gist: https://gist.githubusercontent.com/ahcorde/60de1675ccf6419a09d7f765a912d70b/raw/d10fe8a2cf73b46db6f77889b6373f225b38d65e/ros2.repos
BUILD args: --packages-above-and-dependencies rosbag2_cpp
TEST args: --packages-above rosbag2_cpp
ROS Distro: jazzy
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15766

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit f15eafc into jazzy Apr 24, 2025
11 of 12 checks passed
@ahcorde ahcorde deleted the mergify/bp/jazzy/pr-1962 branch April 24, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

@MichaelOrlov MichaelOrlov Awaiting requested review from MichaelOrlov MichaelOrlov is a code owner automatically assigned from ros2/tooling-reviewers

@hidmic hidmic Awaiting requested review from hidmic hidmic is a code owner automatically assigned from ros2/tooling-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ahcorde