Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize filter with namespaced updated topics and services. (rolling) #1944

Merged
merged 2 commits into from
Mar 24, 2025
Merged

Initialize filter with namespaced updated topics and services. (rolling) #1944

merged 2 commits into from
Mar 24, 2025
+3 −2

Conversation

rodericktaylor
Copy link
Contributor

@rodericktaylor rodericktaylor commented Mar 21, 2025 •
edited by MichaelOrlov
Loading

This is a bugfix for the issue when rosbag2_transport::Recorder doesn't record topics if they named relative to the recorder node's namespace.

@rodericktaylor
Initialize filter with namespaced updated topics.
af149fe 
Signed-off-by: Rod Taylor <rod.taylor@csiro.au>
@rodericktaylor rodericktaylor changed the title Fix relative topics rolling Initialize filter with namespaced updated topics and services. (rolling) Mar 21, 2025
@rodericktaylor
Revert using options member instead of argument.
9924fb1 
Signed-off-by: Rod Taylor <rod.taylor@csiro.au>
@rodericktaylor rodericktaylor force-pushed the fix_relative_topics_rolling branch from 6063984 to 9924fb1 Compare March 21, 2025 00:49
fujitatomoya
fujitatomoya approved these changes Mar 21, 2025
View reviewed changes
Copy link
Contributor

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this makes sense.

MichaelOrlov
MichaelOrlov approved these changes Mar 21, 2025
View reviewed changes
Copy link
Contributor

@MichaelOrlov MichaelOrlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@MichaelOrlov
Copy link
Contributor

Pulls: #1944
Gist: https://gist.githubusercontent.com/MichaelOrlov/b42d7f99db6aa952cb28dc36cade1bcd/raw/82c0ea19df7194d5848f423b39ff61c1c9be5c93/ros2.repos
BUILD args: --packages-above-and-dependencies rosbag2_transport
TEST args: --packages-above rosbag2_transport
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15438

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@rodericktaylor
Copy link
Contributor Author

  • Linux-rhel Build Status
  • Windows Build Status

Does this mean it can't be merged?

@MichaelOrlov
Copy link
Contributor

@rodericktaylor I think we can merge it because:

  1. RHEL CI build failed due to the CI infrastructure issue and has been auto-restarted and passed green * Linux-rhel Build Status
  2. Failure on Windows build is a known issue reported in the [Test Failure] ros2bag.test.test_record_qos_profiles fails on Windows 10 #1947

@MichaelOrlov MichaelOrlov merged commit f41a616 into ros2:rolling Mar 24, 2025
11 checks passed
@MichaelOrlov
Copy link
Contributor

https://github.com/Mergifyio backport jazzy

@mergify Mergify
Copy link

mergify bot commented Mar 24, 2025 •
edited
Loading

backport jazzy

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Mar 24, 2025
@rodericktaylor @mergify
Initialize filter with namespaced updated topics and services. (rolli…
e81bdc0 
…ng) (#1944)

* Initialize filter with namespaced updated topics.

Signed-off-by: Rod Taylor <rod.taylor@csiro.au>

* Revert using options member instead of argument.

Signed-off-by: Rod Taylor <rod.taylor@csiro.au>

---------

Signed-off-by: Rod Taylor <rod.taylor@csiro.au>
(cherry picked from commit f41a616)
@mergify mergify bot mentioned this pull request Mar 24, 2025
Merged
MichaelOrlov pushed a commit that referenced this pull request Mar 26, 2025
@rodericktaylor @MichaelOrlov
Initialize filter with namespaced updated topics and services. (rolli…
f999965 
…ng) (#1944)

* Initialize filter with namespaced updated topics.

Signed-off-by: Rod Taylor <rod.taylor@csiro.au>

* Revert using options member instead of argument.

Signed-off-by: Rod Taylor <rod.taylor@csiro.au>

---------

Signed-off-by: Rod Taylor <rod.taylor@csiro.au>
(cherry picked from commit f41a616)
ahcorde pushed a commit that referenced this pull request Mar 26, 2025
@mergify @rodericktaylor
Initialize filter with namespaced updated topics and services. (rolli…
728c838 
…ng) (#1944) (#1948)

Signed-off-by: Rod Taylor <rod.taylor@csiro.au>
(cherry picked from commit f41a616)

Co-authored-by: Roderick Taylor <Rod.Taylor@csiro.au>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelOrlov MichaelOrlov

@fujitatomoya fujitatomoya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rosbag2_transport::Recorder node does not record topics named relative to that node's namespace.
3 participants
@rodericktaylor @MichaelOrlov @fujitatomoya