Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jazzy] Add bindings to close method in PyReader and PyCompressionReader (#1934) (backport #1935) #1937

Merged
merged 1 commit into from
Mar 24, 2025

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Mar 12, 2025

Adds bindings to the close method through pybind11. Reported in issue #1934.


This is an automatic backport of pull request #1935 done by Mergify.

Signed-off-by: Øystein Sture <os@skarvtech.com>
(cherry picked from commit d3cb4e3)
@mergify mergify bot requested a review from a team as a code owner March 12, 2025 18:39
@mergify mergify bot requested review from gbiggs and emersonknapp and removed request for a team March 12, 2025 18:39
@MichaelOrlov MichaelOrlov changed the title Add bindings to close method in PyReader and PyCompressionReader (#1934) (backport #1935) [jazzy] Add bindings to close method in PyReader and PyCompressionReader (#1934) (backport #1935) Mar 12, 2025
@MichaelOrlov
Copy link
Contributor

Pulls: #1937
Gist: https://gist.githubusercontent.com/MichaelOrlov/7a9ea8161c257d1a05aedfeba4c626ca/raw/f5939e1ddad66179941df8c493993334e4af63fb/ros2.repos
BUILD args: --packages-above-and-dependencies rosbag2_py
TEST args: --packages-above rosbag2_py
ROS Distro: jazzy
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15415

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@MichaelOrlov
Copy link
Contributor

@ros-pull-request-builder retest this please

@MichaelOrlov
Copy link
Contributor

RHEL CI build was restarted

  • Linux-rhel Build Status

@MichaelOrlov
Copy link
Contributor

Re-run Windows CI

  • Windows Build Status

@MichaelOrlov
Copy link
Contributor

@MichaelOrlov MichaelOrlov merged commit 48a9eb8 into jazzy Mar 24, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants