Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Update metadata with new file_info before saving it the first time in the file #1843

Open
wants to merge 1 commit into
base: rolling
Choose a base branch
from

Conversation

MichaelOrlov
Copy link
Contributor

This PR is a bug fix for missing file_info for newly created file in saved metadata.

When we are switching to new storage, the correct behavior shall be as follows:

  1. Save metadata to storage
  2. Close current storage
  3. Open new storage for read_write
  4. Update metadata with a newly created file
  5. Save metadata to storage

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
@MichaelOrlov MichaelOrlov marked this pull request as ready for review October 27, 2024 05:58
@MichaelOrlov MichaelOrlov requested a review from a team as a code owner October 27, 2024 05:58
@MichaelOrlov MichaelOrlov requested review from emersonknapp, jhdcs, christophebedard and fujitatomoya and removed request for a team, emersonknapp and jhdcs October 27, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant