Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add topic_id returned by storage to the TopicMetadata #1538

Merged
merged 4 commits into from
Feb 6, 2024
Merged

Add topic_id returned by storage to the TopicMetadata #1538

merged 4 commits into from
Feb 6, 2024
+271 −219

Commits on Feb 4, 2024

  1. Add topic_id returned by storage to the TopicMetadata 

    - Rationale.
 To be able to distinguish topics by unique topic ID rather than by
 topic name in the future.

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
    @MichaelOrlov
    MichaelOrlov committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    8f1ba79 View commit details
    Browse the repository at this point in the history

  2. Map inner int64_t topic_id to the external uint16_t topic_id in sqlite3 

    Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
    @MichaelOrlov
    MichaelOrlov committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    d9ad603 View commit details
    Browse the repository at this point in the history

  3. Change TopicMetadata::id type to uint16_t 

    Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
    @MichaelOrlov
    MichaelOrlov committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    84b0502 View commit details
    Browse the repository at this point in the history

  4. Use atomic for last_extern_topic_id_ 

    Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
    @MichaelOrlov @fujitatomoya
    MichaelOrlov and fujitatomoya committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    814b513 View commit details
    Browse the repository at this point in the history