-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Player and Recorder Composable (#902) #1419
Commits on Nov 14, 2023
-
Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f50821d - Browse repository at this point
Copy the full SHA f50821dView commit details -
Remove TODO for keyboard handlers
Signed-off-by: roncapat <ronca.pat@gmail.com> Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a08c5d1 - Browse repository at this point
Copy the full SHA a08c5d1View commit details -
Signed-off-by: roncapat <ronca.pat@gmail.com> Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 26ecb08 - Browse repository at this point
Copy the full SHA 26ecb08View commit details -
Signed-off-by: roncapat <ronca.pat@gmail.com> Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c89ce76 - Browse repository at this point
Copy the full SHA c89ce76View commit details -
Signed-off-by: roncapat <ronca.pat@gmail.com> Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2ada177 - Browse repository at this point
Copy the full SHA 2ada177View commit details -
Signed-off-by: roncapat <ronca.pat@gmail.com> Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2c80a2a - Browse repository at this point
Copy the full SHA 2c80a2aView commit details -
Signed-off-by: roncapat <ronca.pat@gmail.com> Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3d7f98d - Browse repository at this point
Copy the full SHA 3d7f98dView commit details -
Signed-off-by: roncapat <ronca.pat@gmail.com> Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f1e0340 - Browse repository at this point
Copy the full SHA f1e0340View commit details -
Draft comparison of passed vs parsed params
Signed-off-by: roncapat <ronca.pat@gmail.com> Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1899416 - Browse repository at this point
Copy the full SHA 1899416View commit details -
Fix shared_from_this() issue, param file & paths
Signed-off-by: roncapat <ronca.pat@gmail.com> Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ee37afc - Browse repository at this point
Copy the full SHA ee37afcView commit details -
Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 863ab6b - Browse repository at this point
Copy the full SHA 863ab6bView commit details -
Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4e65cf0 - Browse repository at this point
Copy the full SHA 4e65cf0View commit details -
Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 874d60d - Browse repository at this point
Copy the full SHA 874d60dView commit details -
Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9f31e3c - Browse repository at this point
Copy the full SHA 9f31e3cView commit details -
Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 52495f8 - Browse repository at this point
Copy the full SHA 52495f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 645b985 - Browse repository at this point
Copy the full SHA 645b985View commit details -
Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6287cd6 - Browse repository at this point
Copy the full SHA 6287cd6View commit details -
Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0aa4cd5 - Browse repository at this point
Copy the full SHA 0aa4cd5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 68bfcb4 - Browse repository at this point
Copy the full SHA 68bfcb4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 95c9d13 - Browse repository at this point
Copy the full SHA 95c9d13View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0205966 - Browse repository at this point
Copy the full SHA 0205966View commit details
Commits on Nov 29, 2023
-
Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for edbb544 - Browse repository at this point
Copy the full SHA edbb544View commit details -
Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 490dc48 - Browse repository at this point
Copy the full SHA 490dc48View commit details -
Get rid of temporal conversion crutches using map<string, Rosbag2QoS>
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
Configuration menu - View commit details
-
Copy full SHA for 21399f2 - Browse repository at this point
Copy the full SHA 21399f2View commit details -
Use const ref to node in the options getter functions
- Also made a style clean up in getter functions Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
Configuration menu - View commit details
-
Copy full SHA for 50f0755 - Browse repository at this point
Copy the full SHA 50f0755View commit details -
Cleanups in get_storage(/play/record)_options functions
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
Configuration menu - View commit details
-
Copy full SHA for 30b1699 - Browse repository at this point
Copy the full SHA 30b1699View commit details -
Move RosBag2RecordTestFixture insight test_record_params.cpp
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
Configuration menu - View commit details
-
Copy full SHA for cfeb0bb - Browse repository at this point
Copy the full SHA cfeb0bbView commit details -
Rename overrides.yaml to the qos_profile_overrides.yaml file
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
Configuration menu - View commit details
-
Copy full SHA for 571a25e - Browse repository at this point
Copy the full SHA 571a25eView commit details -
Rename params_player.yaml to the player_node_params.yaml
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
Configuration menu - View commit details
-
Copy full SHA for 2aa2f8d - Browse repository at this point
Copy the full SHA 2aa2f8dView commit details -
Rename params_recorder.yaml to the recorder_node_params.yaml
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
Configuration menu - View commit details
-
Copy full SHA for fa6e556 - Browse repository at this point
Copy the full SHA fa6e556View commit details -
Replace Rosbag2Duration by rclcpp::Duration
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
Configuration menu - View commit details
-
Copy full SHA for 2d4931c - Browse repository at this point
Copy the full SHA 2d4931cView commit details -
Cleanup in functions which are getting values from node parameters
- Address issues in duration and integer parameters conversion - Introduce `declare_integer_node_params(..)` and `get_duration_from_node_param(..)` helper functions Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
Configuration menu - View commit details
-
Copy full SHA for b493987 - Browse repository at this point
Copy the full SHA b493987View commit details -
Bugfix. Adjust min-max ranges for get_duration_from_node_param(..)
- Also add expected range to the exception message Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
Configuration menu - View commit details
-
Copy full SHA for e98be6e - Browse repository at this point
Copy the full SHA e98be6eView commit details -
Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d396e3c - Browse repository at this point
Copy the full SHA d396e3cView commit details -
Move component manager in fixture
Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e588657 - Browse repository at this point
Copy the full SHA e588657View commit details -
Merge branch 'rolling' into patch-2
Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for fa3eae7 - Browse repository at this point
Copy the full SHA fa3eae7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 89b6736 - Browse repository at this point
Copy the full SHA 89b6736View commit details -
Remove residual AMENT_DEPS after merge
Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2c70406 - Browse repository at this point
Copy the full SHA 2c70406View commit details -
Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 95ab353 - Browse repository at this point
Copy the full SHA 95ab353View commit details -
Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 913e49f - Browse repository at this point
Copy the full SHA 913e49fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9756edd - Browse repository at this point
Copy the full SHA 9756eddView commit details
Commits on Nov 30, 2023
-
Cleanups in player/recorder parameters and load components tests
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
Configuration menu - View commit details
-
Copy full SHA for 0e57485 - Browse repository at this point
Copy the full SHA 0e57485View commit details -
Renames in player/recorder parameters and load components tests
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
Configuration menu - View commit details
-
Copy full SHA for 0641884 - Browse repository at this point
Copy the full SHA 0641884View commit details
Commits on Dec 6, 2023
-
Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4e3f460 - Browse repository at this point
Copy the full SHA 4e3f460View commit details -
Fix load_composable_components test
Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 04948e3 - Browse repository at this point
Copy the full SHA 04948e3View commit details -
Automatically start playback in "composable" Player constructor
- Added doxygen comments for Player's constructors Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
Configuration menu - View commit details
-
Copy full SHA for 1e1d5c3 - Browse repository at this point
Copy the full SHA 1e1d5c3View commit details -
Add integration test for composable player
- Integration test will check that player can automatically play file after composition Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
Configuration menu - View commit details
-
Copy full SHA for 786a08c - Browse repository at this point
Copy the full SHA 786a08cView commit details -
Add missing dependencies to the mock_player.hpp
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
Configuration menu - View commit details
-
Copy full SHA for a611726 - Browse repository at this point
Copy the full SHA a611726View commit details -
Automatically start recording in "composable" Recorder constructor
- Added doxygen comments for Recorder's constructors Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
Configuration menu - View commit details
-
Copy full SHA for 37d7e29 - Browse repository at this point
Copy the full SHA 37d7e29View commit details -
Adopt existent tests for auto starting recording after composition
- Add default "cdr" value for rmw_serialization_format node parameter Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
Configuration menu - View commit details
-
Copy full SHA for 4da289e - Browse repository at this point
Copy the full SHA 4da289eView commit details -
Add integration test for composable recorder
- Test verify that recorder can automatically start recording after composition and record messages Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
Configuration menu - View commit details
-
Copy full SHA for 6192305 - Browse repository at this point
Copy the full SHA 6192305View commit details -
Add missed parameters prefixes after rebase
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
Configuration menu - View commit details
-
Copy full SHA for e89614c - Browse repository at this point
Copy the full SHA e89614cView commit details
Commits on Dec 9, 2023
-
Fix for failing test with wrong check for playback_until_timestamp
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
Configuration menu - View commit details
-
Copy full SHA for 8c283b8 - Browse repository at this point
Copy the full SHA 8c283b8View commit details -
Fix for failing tests with wrong parameters deduction
- Adjust max bagfile size and duration due to the bug in the rc_yaml_param_parcer/parser.c Need to use srtoll() instead of the strol() in parser Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
Configuration menu - View commit details
-
Copy full SHA for 0d446e4 - Browse repository at this point
Copy the full SHA 0d446e4View commit details -
Close recorder before trying to delete temp files on test destruction
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
Configuration menu - View commit details
-
Copy full SHA for 812d9da - Browse repository at this point
Copy the full SHA 812d9daView commit details -
Update rosbag2_transport/test/rosbag2_transport/composition_manager_t…
…est_fixture.hpp Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ee16b40 - Browse repository at this point
Copy the full SHA ee16b40View commit details -
Update rosbag2_transport/test/rosbag2_transport/test_composable_recor…
…der.cpp Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for db3aa34 - Browse repository at this point
Copy the full SHA db3aa34View commit details -
Update rosbag2_transport/CMakeLists.txt
Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for af07a04 - Browse repository at this point
Copy the full SHA af07a04View commit details -
Update rosbag2_transport/CMakeLists.txt
Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6f9bbe8 - Browse repository at this point
Copy the full SHA 6f9bbe8View commit details
Commits on Dec 10, 2023
-
Address warnings from Windows CI job in composable player and recorder
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
Configuration menu - View commit details
-
Copy full SHA for 723a7a8 - Browse repository at this point
Copy the full SHA 723a7a8View commit details
Commits on Dec 11, 2023
-
Update rosbag2_transport/src/rosbag2_transport/config_options_from_no…
…de_params.cpp Co-authored-by: Michael Orlov <morlovmr@gmail.com> Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9110f65 - Browse repository at this point
Copy the full SHA 9110f65View commit details -
Update rosbag2_transport/test/rosbag2_transport/test_composable_playe…
…r.cpp Co-authored-by: Michael Orlov <morlovmr@gmail.com> Signed-off-by: Patrick Roncagliolo <ronca.pat@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8737b72 - Browse repository at this point
Copy the full SHA 8737b72View commit details