Download examples #5840
Draft
Download examples #5840
+136
−130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
sloretz
reviewed
Sep 12, 2025
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
Comment on lines
+459
to
+470
| files_to_download = { | ||
| "publisher_member_function.py": ( | ||
| f"https://raw.githubusercontent.com/ros2/examples/{distro}/" | ||
| "rclpy/topics/minimal_publisher/examples_rclpy_minimal_publisher/" | ||
| "publisher_member_function.py" | ||
| ), | ||
| "subscriber_member_function.py": ( | ||
| f"https://raw.githubusercontent.com/ros2/examples/{distro}/" | ||
| "rclpy/topics/minimal_subscriber/examples_rclpy_minimal_subscriber/" | ||
| "subscriber_member_function.py" | ||
| ), | ||
| } |
There was a problem hiding this comment.
I think this will be hard to maintain. Ideally, we would create a custom directive (..) that takes in the URL to be downloaded and only manage the file/URL/etc. from where it is included in the documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Download requested files then use
literalincludeto have better parity and reduce maintenance. This adds code to support download and updates the python minimal pub/sub example to use it. If this method is approved it can be used for the rest of the examples.Fixes #5839
Did you use Generative AI?
Additional Information