Update Ament-CMake-Documentation.rst #5639
Conversation
cmake version <3.10 is deprecated Signed-off-by: mosfet80 <10235105+mosfet80@users.noreply.github.com>
christophebedard
left a comment
christophebedard
left a comment
There was a problem hiding this comment.
There are other instances of this in the rest of the docs. Would you want to update them in this PR too?
Just search for cmake_minimum_required(VERSION in this repository.
| .. code-block:: cmake | ||
| cmake_minimum_required(VERSION 3.8) | ||
| cmake_minimum_required(VERSION 3.20) |
There was a problem hiding this comment.
you are targeting humble I think the version is right here
There was a problem hiding this comment.
I think you're right that this version is fine for Humble.
REP 2000 lists a bunch of CMake versions for Humble for all the target platforms, and they're all definitely > 3.8: https://www.ros.org/reps/rep-2000.html#humble-hawksbill-may-2022-may-2027. However, it's not that CMake 3.8 is necessarily deprecated: I believe it's actually about declaring a minimum version that's too low (e.g., 3.8) with a newer version of CMake, but Humble (Ubuntu 22.04) has an older version of CMake.
Then I'd just leave this as-is.
|
Given what I said in #5639 (comment), I'll close this PR. Feel free to keep discussing if you disagree. |
3 participants
Description
cmake version <3.10 is deprecated
Did you use Generative AI?
Additional Information