Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor tweak Python publisher tutorial wording #1221

Merged
merged 1 commit into from
Mar 11, 2021
Merged

Minor tweak Python publisher tutorial wording #1221

merged 1 commit into from
Mar 11, 2021

Conversation

mabelzhang
Copy link
Contributor

@mabelzhang mabelzhang commented Mar 11, 2021 •
edited
Loading

Tweaked wording as discovered in response to ros2/examples#303

Following the tutorial, the ament_python dependency is generated inside the <export> tag. The <exec_depend> lines should not be inside that tag. Simplified wording.

@mabelzhang
tweak tutorial wording as found in ros2/examples issue 303
206025b 
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
@mjcarroll mjcarroll had a problem deploying to ros2-documentation-pr-1221 March 11, 2021 09:47 Failure
@clalancette clalancette merged commit e18f606 into foxy Mar 11, 2021
@delete-merged-branch delete-merged-branch bot deleted the mabelzhang/py_tutorial_tweak branch March 11, 2021 12:36
@clalancette
Copy link
Contributor

@Mergifyio backport rolling dashing

mergify bot pushed a commit that referenced this pull request Mar 11, 2021
@mabelzhang
tweak tutorial wording as found in ros2/examples issue 303 (#1221)
21a3d55 
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
(cherry picked from commit e18f606)
@mergify mergify bot mentioned this pull request Mar 11, 2021
Merged
mergify bot pushed a commit that referenced this pull request Mar 11, 2021
@mabelzhang
tweak tutorial wording as found in ros2/examples issue 303 (#1221)
e76179f 
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
(cherry picked from commit e18f606)
@mergify mergify bot mentioned this pull request Mar 11, 2021
Merged
@mergify
Copy link
Contributor

mergify bot commented Mar 11, 2021

Command backport rolling dashing: success

Backports have been created

clalancette pushed a commit that referenced this pull request Mar 11, 2021
@mergify @mabelzhang
tweak tutorial wording as found in ros2/examples issue 303 (#1221) (#…
7602987 
…1224)

Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
(cherry picked from commit e18f606)

Co-authored-by: Mabel Zhang <mabel@openrobotics.org>
clalancette pushed a commit that referenced this pull request Mar 11, 2021
@mergify @mabelzhang
tweak tutorial wording as found in ros2/examples issue 303 (#1221) (#…
3aa4c83 
…1225)

Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
(cherry picked from commit e18f606)

Co-authored-by: Mabel Zhang <mabel@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mabelzhang @clalancette @mjcarroll