Skip to content

Conversation

@esteve
Copy link
Member

@esteve esteve commented Apr 30, 2025

Reverts #1677

@ahcorde
Copy link
Contributor

ahcorde commented Apr 30, 2025

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@christophebedard
Copy link
Member

@mjcarroll from my understanding (and based on my experience with ros2_tracing), if ros2-rust/rosidl_rust is getting added to ros2/ros2, and if it points to main instead of a specific commit or tag, then maintainers of ros2-rust/rosidl_rust should have/be given access to ci.ros2.org, correct? Because then any change getting merged into ros2-rust/rosidl_rust should be tested on ROS 2 CI.

@mjcarroll
Copy link
Member

@mjcarroll from my understanding (and based on my experience with ros2_tracing), if ros2-rust/rosidl_rust is getting added to ros2/ros2, and if it points to main instead of a specific commit or tag, then maintainers of ros2-rust/rosidl_rust should have/be given access to ci.ros2.org, correct? Because then any change getting merged into ros2-rust/rosidl_rust should be tested on ROS 2 CI.

This matches my understanding. @esteve is this something that you would be okay with and interested in doing?

@esteve
Copy link
Member Author

esteve commented May 12, 2025

@christophebedard @mjcarroll sorry for the slow response, I've been mostly sick since last time. I already have access to ci.ros2.org, perhaps as having been a member of some team or something like that. In any case, yeah, I agree that it rosidl_generator_rs should be tested via the ROS 2 CI. We already have a CI setup in the ros2-rust org, but it tests only the ros2-rust-specific packages, and not as part of a larger ROS 2 system.

@christophebedard
Copy link
Member

There are no new changes since ros2-rust/rosidl_rust#3 and CI looks good; I think this is ready.

@esteve
Copy link
Member Author

esteve commented May 22, 2025

@christophebedard @mjcarroll do you guys have any more feedback I should address? Once this is merged, I'd like to write a post on Discourse about it, so excited to be getting Rust into ROS!

@mjcarroll mjcarroll changed the title Revert "Revert "Added rosidl_rust repository"" Added rosidl_rust repository May 22, 2025
@mjcarroll mjcarroll merged commit 26c0409 into rolling May 22, 2025
2 checks passed
@mjcarroll
Copy link
Member

@esteve if you would like, when the kilted release post goes up tomorrow, maybe a good place to comment?

@christophebedard christophebedard deleted the revert-1677-revert-1674-add-rosidl_rust branch May 22, 2025 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants