Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parametrize Quality of Service in parameter_bridge. #331

Merged
merged 14 commits into from
Jun 22, 2022
Merged

Parametrize Quality of Service in parameter_bridge. #331

merged 14 commits into from
Jun 22, 2022

Commits on Oct 18, 2021

  1. Extend create_bidirectional_bridge to take qos param for ROS2 publisher 

    Signed-off-by: Loy van Beek <loy.vanbeek@mojin-robotics.de>
    @LoyVanBeek
    LoyVanBeek committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    ba6e72c View commit details
    Browse the repository at this point in the history

  2. Busy setting up a way to read QoS parameters from ROS1 params 

    Signed-off-by: Loy van Beek <loy.vanbeek@mojin-robotics.de>
    @LoyVanBeek
    LoyVanBeek committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    7dd23c3 View commit details
    Browse the repository at this point in the history

  3. Parse history qos params 

    Signed-off-by: Loy van Beek <loy.vanbeek@mojin-robotics.de>
    @LoyVanBeek
    LoyVanBeek committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    f9dcb47 View commit details
    Browse the repository at this point in the history

  4. Call qos_from_params when setting up topics 

    Signed-off-by: Loy van Beek <loy.vanbeek@mojin-robotics.de>
    @LoyVanBeek
    LoyVanBeek committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    5909480 View commit details
    Browse the repository at this point in the history

  5. Configure deadline, lifespan, liveliness_lease_durations 

    Signed-off-by: Loy van Beek <loy.vanbeek@mojin-robotics.de>
    @LoyVanBeek
    LoyVanBeek committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    0846b9f View commit details
    Browse the repository at this point in the history

  6. Configure liveliness 

    Signed-off-by: Loy van Beek <loy.vanbeek@mojin-robotics.de>
    @LoyVanBeek
    LoyVanBeek committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    d408ac0 View commit details
    Browse the repository at this point in the history

  7. Add some basic debug text 

    Signed-off-by: Loy van Beek <loy.vanbeek@mojin-robotics.de>
    @LoyVanBeek
    LoyVanBeek committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    4dd0ef0 View commit details
    Browse the repository at this point in the history

  8. Print the QoS settings to stdout when setting them up 

    Signed-off-by: Loy van Beek <loy.vanbeek@mojin-robotics.de>
    @LoyVanBeek
    LoyVanBeek committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    148e261 View commit details
    Browse the repository at this point in the history

  9. Catch XmlRpc::XmlRpcExceptions when constructing QoS from parameters 

    Signed-off-by: Loy van Beek <loy.vanbeek@mojin-robotics.de>
    @LoyVanBeek
    LoyVanBeek committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    6f13f2c View commit details
    Browse the repository at this point in the history

  10. Parse liveliness as either int enum value or upper/lower case string … 

    …representation of liveliness enum values

Signed-off-by: Loy van Beek <loy.vanbeek@mojin-robotics.de>
    @LoyVanBeek
    LoyVanBeek committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    b777cbf View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2021

  1. Fix formatting with uncrustify 

    Signed-off-by: Loy van Beek <loy.vanbeek@mojin-robotics.de>
    @LoyVanBeek
    LoyVanBeek committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    774330e View commit details
    Browse the repository at this point in the history

  2. Fix cpplint formatting 

    In 2 cases the formatting conflicts with what uncrustify wants; // NOLINT got rid of the complaints of cpplint, favouring uncrustify

Signed-off-by: Loy van Beek <loy.vanbeek@mojin-robotics.de>
    @LoyVanBeek
    LoyVanBeek committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    4796dcf View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2021

  1. Clearer logging as suggested by code review 

    Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>
Signed-off-by: Loy van Beek <loy.vanbeek@mojin-robotics.de>
    @LoyVanBeek @gbiggs
    LoyVanBeek and gbiggs committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    c078d34 View commit details
    Browse the repository at this point in the history

  2. Clarify keep_last vs keep_all setting for history 

    Signed-off-by: Loy van Beek <loy.vanbeek@mojin-robotics.de>
    @LoyVanBeek
    LoyVanBeek committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    ec44770 View commit details
    Browse the repository at this point in the history