Fix logging for updated rclcpp interface#303
Merged
Merged
Conversation
Signed-off-by: Michael Carroll <michael@openrobotics.org>
ivanpauno
approved these changes
Dec 21, 2020
Signed-off-by: Michael Carroll <michael@openrobotics.org> Co-authored-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
ivanpauno
reviewed
Dec 21, 2020
audrow
reviewed
Dec 21, 2020
audrow
left a comment
audrow
left a comment
Member
There was a problem hiding this comment.
I think Clang will raise a warning with the change that's been made. I've suggested two alternatives.
Member
|
Also, this is an expected side effect. After ros2/rclcpp#1442, the logging macros only accept |
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Member
Author
|
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Member
Author
|
This actually requires the ci_packaging job, since it's ros1_bridge: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has caused failures in the nightly jobs on platforms where ros1_bridge is built.
I believe that it is related to this PR: ros2/rclcpp#1442
@audrow Can you confirm that this was an expected side effect?