Updated zenoh-c to latest commit #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yadunund
requested changes
Apr 26, 2024
|
I think I'm a little confused by this PR. As far as I understood, if we bump to the latest |
|
Hello @clalancette! This pull request targets the branch to evaluate rmw with Tokio zenoh-c. Although the current hash already corresponds to Tokio zenoh-c, it's a few weeks outdated. Hence, we believe it's prudent to update this branch to the latest Tokio zenoh-c version and rerun the tests to assess any potential improvements or regressions. |
Yadunund
added a commit
that referenced
this pull request
May 8, 2024
* Sync past tokio bump and drop thread restriction Signed-off-by: Yadunund <yadunund@openrobotics.org> * Bump zenoh-c to eclipse-zenoh/zenoh-c#307 * Updated zenoh-c to latest commit (#164) * updated zenoh-c to latest commit * updated zenoh-c commit comment * Updated comment in cmake --------- Signed-off-by: Yadunund <yadunund@openrobotics.org> Co-authored-by: Julien Enoch <julien.e@zettascale.tech> Co-authored-by: Steven Palma <imstevenpmwork@ieee.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @Yadunund!
We're submitting this PR to ensure we use the latest zenoh-c commit before proceeding with our planned testing