Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump zenoh-c to eclipse-zenoh/zenoh-c#307 , fixing issues with Tokio runtime #146

Merged

Conversation

JEnoch
Copy link
Contributor

@JEnoch JEnoch commented Apr 3, 2024

This PR does:

With this PR I managed to sucessfuly run the following demos:

AlexDayCRL and others added 4 commits March 27, 2024 08:26
* Patch cargo toolchain for noble

Signed-off-by: Yadunund <yadunund@openrobotics.org>

* Add tmp build for noble job

Signed-off-by: Yadunund <yadunund@openrobotics.org>

* Try to fix iron

Signed-off-by: Yadunund <yadunund@openrobotics.org>

* Patch even for iron builds

Signed-off-by: Yadunund <yadunund@openrobotics.org>

* Force build with 1.75.0 on jammy

Signed-off-by: Yadunund <yadunund@openrobotics.org>

* Update zenoh_c_vendor/CMakeLists.txt

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Yadu <yadunund@gmail.com>

* Update zenoh_c_vendor/CMakeLists.txt

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Yadu <yadunund@gmail.com>

* Update zenoh_c_vendor/CMakeLists.txt

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Yadu <yadunund@gmail.com>

* Patch zenoh-c based on cargo toolchain availability

Signed-off-by: Yadunund <yadunund@openrobotics.org>

* Make patch from zenoh-c PR ros2#301

Signed-off-by: Yadunund <yadunund@openrobotics.org>

---------

Signed-off-by: Yadunund <yadunund@openrobotics.org>
Signed-off-by: Yadu <yadunund@gmail.com>
Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Copy link
Member

@Yadunund Yadunund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this first and test with the base branch. Thanks for lot for identifying and testing the fix 🙏🏼

@Yadunund Yadunund merged commit 063a850 into ros2:yadu/bump_zenoh_with_tokio Apr 4, 2024
5 of 6 checks passed
@JEnoch JEnoch mentioned this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants