This repository has been archived by the owner on Oct 7, 2021. It is now read-only.
Use rcpputils::find_and_replace instead of std::regex_replace #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rcpputils implementation is more performant. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
sloretz
approved these changes
Jun 10, 2019
|
|
After running CI against master (#264 (comment)), it looks like the test failures already exist and are related to builds with OpenSplice. |
dirk-thomas
reviewed
Jul 15, 2019
| find_package(rcutils REQUIRED) | ||
| find_package(rmw REQUIRED) | ||
| find_package(rosidl_generator_c REQUIRED) | ||
| find_package(rosidl_generator_cpp REQUIRED) | ||
|
|
||
| ament_export_dependencies( | ||
| rcpputils |
There was a problem hiding this comment.
@jacobperron The package exports the rcpputils dependency but doesn't declare that run dependency in the manifest.
jacobperron
added a commit
that referenced
this pull request
Jul 26, 2019
The rcpputils implementation is more performant. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
added a commit
that referenced
this pull request
Jul 29, 2019
The rcpputils implementation is more performant. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
cwyark
pushed a commit
to cwyark/rmw_opensplice
that referenced
this pull request
Jul 31, 2019
The rcpputils implementation is more performant. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
cwyark
pushed a commit
to cwyark/rmw_opensplice
that referenced
this pull request
Jul 31, 2019
The rcpputils implementation is more performant. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rcpputils implementation is more performant.
Relates to ros2/rmw_fastrtps#277
Requires ros2/rcpputils#13