Skip to content
This repository has been archived by the owner on Oct 7, 2021. It is now read-only.

Don't error if Sample_ prefix not found in service type #240

Merged
merged 1 commit into from
Jun 29, 2018
Merged

Conversation

dhood
Copy link
Member

@dhood dhood commented Jun 29, 2018

fixes #239 (context is there)

@dhood dhood added the in review Waiting for review (Kanban column) label Jun 29, 2018
@dhood dhood added this to the bouncy milestone Jun 29, 2018
@dhood dhood self-assigned this Jun 29, 2018
Copy link
Member

@mikaelarguedas mikaelarguedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with green CI, thanks @dhood

@dhood
Copy link
Member Author

dhood commented Jun 29, 2018

Full CI only opensplice

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Bridge testing: Build Status

@dhood dhood merged commit 4a6c0be into master Jun 29, 2018
@dhood dhood deleted the fix_239 branch June 29, 2018 23:16
@dhood dhood removed the in review Waiting for review (Kanban column) label Jun 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rmw_get_service_names_and_types should support other RMW's service types
2 participants