Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MSBuild warnings C4146 and C4267 #98

Merged
merged 2 commits into from
Feb 11, 2020

Conversation

emersonknapp
Copy link
Contributor

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
@emersonknapp
Copy link
Contributor Author

myself - please run this CI job
Gist: https://gist.githubusercontent.com/emersonknapp/a65f8b1f5e441f692fe333a9d12b42c0/raw/d66d8d4ca569892224ca2f8dcf6cc8c5cb210e97/ros2.repos
BUILD args: --packages-up-to rmw_cyclonedds_cpp
TEST args: --packages-select rmw_cyclonedds_cpp
Job: ci_launcher

@emersonknapp
Copy link
Contributor Author

emersonknapp commented Feb 7, 2020

Windows packaging job first before full run

Windows Packaging: Build Status

@emersonknapp
Copy link
Contributor Author

emersonknapp commented Feb 7, 2020

Full run

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status
  • Windows-container Build Status

EDIT 2: I forgot that the checkbox for RMW implementations need to be set on ci_launcher runs, my mistake

@nuclearsandwich
Copy link
Member

EDIT: The CI builds are hardcoded internally to explicitly ignore rmw_cyclonedds_cpp so they are failing trying to find it - @nuclearsandwich any advice on that?

For RMW implementations specific Jenkins parameters need to be enabled.
When using ci_launcher you can enable or disable specific RMW and the disabled ones will be ignored. In this case there was a mismatch between the enabled RMW and the selected packages. I've re-triggered the launcher job above with CI_USE_CYCLONEDDS enabled.

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status
  • Windows-container Build Status

@emersonknapp
Copy link
Contributor Author

Ohh I forgot about the checkboxes, thank you!

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
@emersonknapp
Copy link
Contributor Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status
  • Windows-container Build Status

@emersonknapp
Copy link
Contributor Author

@eboasson addressed by using one of your suggestions, MSBuild seems happy with 0 - x, good idea. The OSX builds are failing across the board for infrastructural reasons, so if the Windows-container build passes I'd propose we merge.

Copy link
Collaborator

@eboasson eboasson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Good to know that this at least works :)

The windows-container build seems to be failing for completely different reasons, so as far as I am concerned it can be merged already.

@emersonknapp
Copy link
Contributor Author

Great! Do you have merge access? I do not for this repository.

@eboasson
Copy link
Collaborator

@emersonknapp, I do (I'm the original author of the repository, even if it was @rotu who did the hard work of making the serializer perform well).

@eboasson eboasson merged commit cf8e4fb into ros2:master Feb 11, 2020
@emersonknapp
Copy link
Contributor Author

Thanks!

@emersonknapp emersonknapp deleted the fix-msbuild-warnings branch February 11, 2020 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MSBuild warnings in serdata.cpp
3 participants