Fix MSBuild warnings C4146 and C4267

[emersonknapp]

Closes #90
Closes https://github.com/ros-tooling/aws-oncall/issues/66

Signed-off-by: Emerson Knapp emerson.b.knapp@gmail.com

[emersonknapp]

myself - please run this CI job
Gist: https://gist.githubusercontent.com/emersonknapp/a65f8b1f5e441f692fe333a9d12b42c0/raw/d66d8d4ca569892224ca2f8dcf6cc8c5cb210e97/ros2.repos
BUILD args: --packages-up-to rmw_cyclonedds_cpp
TEST args: --packages-select rmw_cyclonedds_cpp
Job: ci_launcher

[emersonknapp]

Windows packaging job first before full run

Windows Packaging:

[emersonknapp]

Full run

• Linux
• Linux-aarch64
• macOS
• Windows
• Windows-container

EDIT 2: I forgot that the checkbox for RMW implementations need to be set on ci_launcher runs, my mistake

[nuclearsandwich]

EDIT: The CI builds are hardcoded internally to explicitly ignore rmw_cyclonedds_cpp so they are failing trying to find it - @nuclearsandwich any advice on that?

For RMW implementations specific Jenkins parameters need to be enabled.
When using ci_launcher you can enable or disable specific RMW and the disabled ones will be ignored. In this case there was a mismatch between the enabled RMW and the selected packages. I've re-triggered the launcher job above with CI_USE_CYCLONEDDS enabled.

• Linux
• Linux-aarch64
• macOS
• Windows
• Windows-container

[emersonknapp]

Ohh I forgot about the checkboxes, thank you!

[emersonknapp]

• Linux
• Linux-aarch64
• macOS
• Windows
• Windows-container

[emersonknapp]

@eboasson addressed by using one of your suggestions, MSBuild seems happy with 0 - x, good idea. The OSX builds are failing across the board for infrastructural reasons, so if the Windows-container build passes I'd propose we merge.

[eboasson]

Thanks! Good to know that this at least works :)

The windows-container build seems to be failing for completely different reasons, so as far as I am concerned it can be merged already.

[emersonknapp]

Great! Do you have merge access? I do not for this repository.

[eboasson]

@emersonknapp, I do (I'm the original author of the repository, even if it was @rotu who did the hard work of making the serializer perform well).

[emersonknapp]

Thanks!