Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use RMW_GID_STORAGE_SIZE to client_service_id_t. #515

Merged
merged 1 commit into from
Oct 8, 2024
Merged

use RMW_GID_STORAGE_SIZE to client_service_id_t. #515

merged 1 commit into from
Oct 8, 2024

Conversation

fujitatomoya
Copy link
Contributor

minor fix to remove redundant check and lint, aligns with ros2/rmw#345

@fujitatomoya
use RMW_GID_STORAGE_SIZE to client_service_id_t.
4018b17 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya
Copy link
Contributor Author

@clalancette @eboasson could you take a look?

@fujitatomoya
Copy link
Contributor Author

Pulls: #515
Gist: https://gist.githubusercontent.com/fujitatomoya/159fb39f654e136e969ca6830c5c3534/raw/8d12400542ede7611dcdb6b3391fe546e94c2271/ros2.repos
BUILD args: --packages-above-and-dependencies rmw_cyclonedds_cpp
TEST args: --packages-above rmw_cyclonedds_cpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14676

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

clalancette
clalancette approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me.

@fujitatomoya
Copy link
Contributor Author

https://ci.ros2.org/job/ci_linux-rhel/1478/ is related, that is ros2cli missing the result...

since i do not have write permission here, i like to ask @clalancette @eboasson to merge this.

@clalancette clalancette merged commit 0c2904d into ros2:rolling Oct 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@eboasson eboasson Awaiting requested review from eboasson eboasson is a code owner

@ivanpauno ivanpauno Awaiting requested review from ivanpauno ivanpauno is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fujitatomoya @clalancette