New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't check lifespan on subscriber QoS #523

Merged

jacobperron merged 1 commit into ros2:master from rotu:pr-1

Mar 12, 2020

Contributor

rotu commented Mar 10, 2020

Similar to changes in ros2/rcl#571 and ros2/rclcpp#1002
Fixes CI issue http://build.ros2.org/view/Fci/job/Fci__nightly-cyclonedds_ubuntu_focal_amd64/lastCompletedBuild/testReport/rclpy.src.ros2.rclpy.rclpy.test.test_node/TestNodeAllowUndeclaredParameters/test_get_publishers_subscriptions_info_by_topic/
Signed-off-by: Dan Rose dan@digilabs.io


          Don't check lifespan on subscriber QoS

67fd591

Similar to changes in ros2/rcl#571 and ros2/rclcpp#1002
Fixes CI issue http://build.ros2.org/view/Fci/job/Fci__nightly-cyclonedds_ubuntu_focal_amd64/lastCompletedBuild/testReport/rclpy.src.ros2.rclpy.rclpy.test.test_node/TestNodeAllowUndeclaredParameters/test_get_publishers_subscriptions_info_by_topic/
Signed-off-by: Dan Rose <dan@digilabs.io>

Contributor Author

rotu commented Mar 11, 2020

@jacobperron, could you please review this?

jacobperron self-requested a review

March 11, 2020 18:20

Member

jacobperron commented Mar 12, 2020

Linux
Linux-aarch64
macOS
Windows

Warnings and test failures are unrelated.

jacobperron approved these changes

View reviewed changes

Member

jacobperron left a comment

Thanks for the patch!

jacobperron merged commit 211da41 into ros2:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet