Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Every executor gets its own SIGINT guard condition #308

Merged
merged 25 commits into from
Apr 19, 2019
Merged

Every executor gets its own SIGINT guard condition #308

merged 25 commits into from
Apr 19, 2019

Commits on Apr 8, 2019

  1. Every executor gets its own SIGINT guard condition 

    Moves signal handling code to _rclpy_signal_handler
Every executor adds a guard condition to a global list
SIGINT signal handler triggers all guard conditions in global list

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
    @sloretz
    sloretz committed Apr 8, 2019
    Configuration menu
    Copy the full SHA
    dda3de0 View commit details
    Browse the repository at this point in the history

  2. _sigint_gc robust to shutdown() called twice 

    Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
    @sloretz
    sloretz committed Apr 8, 2019
    Configuration menu
    Copy the full SHA
    6690335 View commit details
    Browse the repository at this point in the history

  3. Remove redundant comments 

    Comments say the same thing twice.
It only needs to be said once.
Remove extra comments so the same thing is not repeated.

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
    @sloretz
    sloretz committed Apr 8, 2019
    Configuration menu
    Copy the full SHA
    d48b195 View commit details
    Browse the repository at this point in the history

  4. Split loop for readability 

    Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
    @sloretz
    sloretz committed Apr 8, 2019
    Configuration menu
    Copy the full SHA
    506fb44 View commit details
    Browse the repository at this point in the history

  5. g_guard_conditions atomic variable 

    Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
    @sloretz
    sloretz committed Apr 8, 2019
    1 Configuration menu
    Copy the full SHA
    3538874 View commit details
    Browse the repository at this point in the history

  6. Use rclutils_atomics macros 

    Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
    @sloretz
    sloretz committed Apr 8, 2019
    Configuration menu
    Copy the full SHA
    a2b1aaf View commit details
    Browse the repository at this point in the history

  7. Call original handler before losing reference to it 

    Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
    @sloretz
    sloretz committed Apr 8, 2019
    Configuration menu
    Copy the full SHA
    3b250ab View commit details
    Browse the repository at this point in the history

  8. remove extra unnecessary assignment 

    Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
    @sloretz
    sloretz committed Apr 8, 2019
    Configuration menu
    Copy the full SHA
    081c921 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2019

  1. g_guard_conditions is a struct on windows 

    Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
    @sloretz
    sloretz committed Apr 10, 2019
    Configuration menu
    Copy the full SHA
    6181a03 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2019

  1. Rename action state transitions (#300) 

    * Rename action state transitions

Now using active verbs as described in the design doc:

http://design.ros2.org/articles/actions.html#goal-states

Connects to ros2/rcl#399.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
    @jacobperron
    jacobperron authored Apr 16, 2019
    Configuration menu
    Copy the full SHA
    4802211 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2019

  1. add missing error handling and cleanup (#315) 

    Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
    @dirk-thomas
    dirk-thomas authored Apr 17, 2019
    Configuration menu
    Copy the full SHA
    dcf1971 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2019

  1. Don't store sigint_gc address 

    Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
    @sloretz
    sloretz committed Apr 19, 2019
    Configuration menu
    Copy the full SHA
    28d9f55 View commit details
    Browse the repository at this point in the history

  2. remove redundant conditional 

    Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
    @sloretz
    sloretz committed Apr 19, 2019
    Configuration menu
    Copy the full SHA
    3d25d7f View commit details
    Browse the repository at this point in the history

  3. Every executor gets its own SIGINT guard condition 

    Moves signal handling code to _rclpy_signal_handler
Every executor adds a guard condition to a global list
SIGINT signal handler triggers all guard conditions in global list

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
    @sloretz
    sloretz committed Apr 19, 2019
    Configuration menu
    Copy the full SHA
    f0a8dc6 View commit details
    Browse the repository at this point in the history

  4. _sigint_gc robust to shutdown() called twice 

    Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
    @sloretz
    sloretz committed Apr 19, 2019
    Configuration menu
    Copy the full SHA
    dd17671 View commit details
    Browse the repository at this point in the history

  5. Remove redundant comments 

    Comments say the same thing twice.
It only needs to be said once.
Remove extra comments so the same thing is not repeated.

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
    @sloretz
    sloretz committed Apr 19, 2019
    Configuration menu
    Copy the full SHA
    4d706fe View commit details
    Browse the repository at this point in the history

  6. Split loop for readability 

    Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
    @sloretz
    sloretz committed Apr 19, 2019
    Configuration menu
    Copy the full SHA
    c8da2f1 View commit details
    Browse the repository at this point in the history

  7. g_guard_conditions atomic variable 

    Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
    @sloretz
    sloretz committed Apr 19, 2019
    Configuration menu
    Copy the full SHA
    83e1edb View commit details
    Browse the repository at this point in the history

  8. Use rclutils_atomics macros 

    Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
    @sloretz
    sloretz committed Apr 19, 2019
    Configuration menu
    Copy the full SHA
    215fb99 View commit details
    Browse the repository at this point in the history

  9. Call original handler before losing reference to it 

    Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
    @sloretz
    sloretz committed Apr 19, 2019
    Configuration menu
    Copy the full SHA
    63b2852 View commit details
    Browse the repository at this point in the history

  10. remove extra unnecessary assignment 

    Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
    @sloretz
    sloretz committed Apr 19, 2019
    Configuration menu
    Copy the full SHA
    f0dcb16 View commit details
    Browse the repository at this point in the history

  11. g_guard_conditions is a struct on windows 

    Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
    @sloretz
    sloretz committed Apr 19, 2019
    Configuration menu
    Copy the full SHA
    571470c View commit details
    Browse the repository at this point in the history

  12. Don't store sigint_gc address 

    Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
    @sloretz
    sloretz committed Apr 19, 2019
    Configuration menu
    Copy the full SHA
    b12ff20 View commit details
    Browse the repository at this point in the history

  13. remove redundant conditional 

    Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
    @sloretz
    sloretz committed Apr 19, 2019
    Configuration menu
    Copy the full SHA
    ea96b9f View commit details
    Browse the repository at this point in the history

  14. Merge branch 'sloretz/multiple_sigint_gcs' of https://github.com/ros2… 

    …/rclpy into sloretz/multiple_sigint_gcs
    @sloretz
    sloretz committed Apr 19, 2019
    Configuration menu
    Copy the full SHA
    5e92624 View commit details
    Browse the repository at this point in the history